Skip to content

Commit eb46b8b

Browse files
devversionjosephperrott
authored andcommitted
build: do not load tslib and moment twice in tests (angular#14715)
* SystemJS is responsible for loading `tslib` and `moment` as registered AMD modules. This means that we don't need to include them in Karma as well. Currently the browsers fetches Moment and tslib twice and also runs it without having any necessary effect.
1 parent 12aa413 commit eb46b8b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/karma.conf.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ module.exports = config => {
1515
],
1616
files: [
1717
{pattern: 'node_modules/core-js/client/core.min.js', included: true, watched: false},
18-
{pattern: 'node_modules/tslib/tslib.js', included: true, watched: false},
18+
{pattern: 'node_modules/tslib/tslib.js', included: false, watched: false},
1919
{pattern: 'node_modules/systemjs/dist/system.js', included: true, watched: false},
2020
{pattern: 'node_modules/zone.js/dist/zone.min.js', included: true, watched: false},
2121
{pattern: 'node_modules/zone.js/dist/proxy.min.js', included: true, watched: false},
@@ -24,7 +24,7 @@ module.exports = config => {
2424
{pattern: 'node_modules/zone.js/dist/async-test.js', included: true, watched: false},
2525
{pattern: 'node_modules/zone.js/dist/fake-async-test.js', included: true, watched: false},
2626
{pattern: 'node_modules/hammerjs/hammer.min.js', included: true, watched: false},
27-
{pattern: 'node_modules/moment/min/moment-with-locales.min.js', included: true, watched: false},
27+
{pattern: 'node_modules/moment/min/moment-with-locales.min.js', included: false, watched: false},
2828

2929
// Include all Angular dependencies
3030
{pattern: 'node_modules/@angular/**/*', included: false, watched: false},

0 commit comments

Comments
 (0)