Skip to content

update documentation for helper #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2024

Conversation

kkmuffme
Copy link
Contributor

Fix #345

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@kkmuffme
Copy link
Contributor Author

@mgol will the CLA company be publically visible? (have to clarify this before running it with our cla manager and sign the CLA)

@mgol
Copy link
Member

mgol commented Jan 13, 2023

@kkmuffme I don't know the answer to this question but I asked at the OpenJS Foundation, hopefully you'll get an answer.

@lukeschantz
Copy link

I asked some folks with experience with the CLA and here is the response "the only thing that is visible in the PR is whether or not the CLA check passed or failed (and, if it failed, which commit authors failed the check). So, no, it wouldn't be publicly visible."

@kkmuffme
Copy link
Contributor Author

Thanks, there's a bug awith EasyCLA atm and signing new CLAs doesn't work; waiting for their reply and fix (will be at least a week though from what I gathered)

@kkmuffme
Copy link
Contributor Author

@mgol ready to be merged

@mgol mgol merged commit 68d36a8 into jquery:main May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Sortable - helper arg & return types unclear if jQuery or JS?
3 participants