Skip to content

Commit e224e31

Browse files
committed
Break almost all dependencies of Driver on Frontend
- Sink OutputFileMap{.h,.cpp} and ReferenceDependencyKeys.h to Basic - Remove unnecessary includes of Frontend.h.
1 parent 140ee56 commit e224e31

18 files changed

+20
-22
lines changed

include/swift/Frontend/OutputFileMap.h renamed to include/swift/Basic/OutputFileMap.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//===--- OutputFileMap.h - Driver output file map ---------------*- C++ -*-===//
1+
//===--- OutputFileMap.h - Map of inputs to multiple outputs ----*- C++ -*-===//
22
//
33
// This source file is part of the Swift.org open source project
44
//
@@ -10,8 +10,8 @@
1010
//
1111
//===----------------------------------------------------------------------===//
1212

13-
#ifndef SWIFT_DRIVER_OUTPUTFILEMAP_H
14-
#define SWIFT_DRIVER_OUTPUTFILEMAP_H
13+
#ifndef SWIFT_BASIC_OUTPUTFILEMAP_H
14+
#define SWIFT_BASIC_OUTPUTFILEMAP_H
1515

1616
#include "swift/Basic/FileTypes.h"
1717
#include "swift/Basic/LLVM.h"

include/swift/Frontend/ReferenceDependencyKeys.h renamed to include/swift/Basic/ReferenceDependencyKeys.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22
//
33
// This source file is part of the Swift.org open source project
44
//
5-
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
5+
// Copyright (c) 2014 - 2018 Apple Inc. and the Swift project authors
66
// Licensed under Apache License v2.0 with Runtime Library Exception
77
//
88
// See https://swift.org/LICENSE.txt for license information
99
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1010
//
1111
//===----------------------------------------------------------------------===//
1212

13-
#ifndef SWIFT_FRONTENDTOOL_REFERENCEDEPENDENCYKEYS_H
14-
#define SWIFT_FRONTENDTOOL_REFERENCEDEPENDENCYKEYS_H
13+
#ifndef SWIFT_BASIC_REFERENCEDEPENDENCYKEYS_H
14+
#define SWIFT_BASIC_REFERENCEDEPENDENCYKEYS_H
1515

1616
#include "swift/Basic/LLVM.h"
1717
#include "llvm/ADT/StringRef.h"

include/swift/Driver/Compilation.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@
1919

2020
#include "swift/Basic/ArrayRefView.h"
2121
#include "swift/Basic/LLVM.h"
22+
#include "swift/Basic/OutputFileMap.h"
2223
#include "swift/Basic/Statistic.h"
2324
#include "swift/Driver/Driver.h"
2425
#include "swift/Driver/Job.h"
2526
#include "swift/Driver/Util.h"
26-
#include "swift/Frontend/OutputFileMap.h"
2727
#include "llvm/ADT/DenseSet.h"
2828
#include "llvm/ADT/StringRef.h"
2929
#include "llvm/Support/Chrono.h"

include/swift/Driver/Driver.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
#include "swift/Basic/FileTypes.h"
2222
#include "swift/Basic/LLVM.h"
2323
#include "swift/Basic/OptionSet.h"
24+
#include "swift/Basic/OutputFileMap.h"
2425
#include "swift/Basic/Sanitizers.h"
2526
#include "swift/Driver/Util.h"
26-
#include "swift/Frontend/OutputFileMap.h"
2727
#include "llvm/ADT/DenseMap.h"
2828
#include "llvm/ADT/StringMap.h"
2929
#include "llvm/ADT/StringRef.h"

include/swift/Driver/Job.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515

1616
#include "swift/Basic/FileTypes.h"
1717
#include "swift/Basic/LLVM.h"
18+
#include "swift/Basic/OutputFileMap.h"
1819
#include "swift/Driver/Action.h"
1920
#include "swift/Driver/Util.h"
20-
#include "swift/Frontend/OutputFileMap.h"
2121
#include "llvm/ADT/ArrayRef.h"
2222
#include "llvm/ADT/DenseMap.h"
2323
#include "llvm/ADT/PointerIntPair.h"

lib/Basic/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ add_swift_library(swiftBasic STATIC
7878
LangOptions.cpp
7979
LLVMContext.cpp
8080
Mangler.cpp
81+
OutputFileMap.cpp
8182
Platform.cpp
8283
PrefixMap.cpp
8384
PrettyStackTrace.cpp

lib/Frontend/OutputFileMap.cpp renamed to lib/Basic/OutputFileMap.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//===--- OutputFileMap.cpp - Driver output file map -----------------------===//
1+
//===--- OutputFileMap.h - Map of inputs to multiple outputs --------------===//
22
//
33
// This source file is part of the Swift.org open source project
44
//
@@ -10,7 +10,7 @@
1010
//
1111
//===----------------------------------------------------------------------===//
1212

13-
#include "swift/Frontend/OutputFileMap.h"
13+
#include "swift/Basic/OutputFileMap.h"
1414
#include "llvm/ADT/SmallString.h"
1515
#include "llvm/ADT/StringRef.h"
1616
#include "llvm/Support/Path.h"

lib/Driver/Compilation.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
#include "swift/AST/DiagnosticEngine.h"
1616
#include "swift/AST/DiagnosticsDriver.h"
17+
#include "swift/Basic/OutputFileMap.h"
1718
#include "swift/Basic/Program.h"
1819
#include "swift/Basic/STLExtras.h"
1920
#include "swift/Basic/Statistic.h"
@@ -26,7 +27,6 @@
2627
#include "swift/Driver/Job.h"
2728
#include "swift/Driver/ParseableOutput.h"
2829
#include "swift/Driver/ToolChain.h"
29-
#include "swift/Frontend/OutputFileMap.h"
3030
#include "swift/Option/Options.h"
3131
#include "llvm/ADT/DenseSet.h"
3232
#include "llvm/ADT/MapVector.h"

lib/Driver/DarwinToolChains.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
#include "swift/Basic/LLVM.h"
1717
#include "swift/Basic/Platform.h"
1818
#include "swift/Basic/Range.h"
19+
#include "swift/Basic/STLExtras.h"
1920
#include "swift/Basic/TaskQueue.h"
2021
#include "swift/Config.h"
2122
#include "swift/Driver/Compilation.h"
2223
#include "swift/Driver/Driver.h"
2324
#include "swift/Driver/Job.h"
24-
#include "swift/Frontend/Frontend.h"
2525
#include "swift/Option/Options.h"
2626
#include "clang/Basic/Version.h"
2727
#include "clang/Driver/Util.h"

lib/Driver/DependencyGraph.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
//
1111
//===----------------------------------------------------------------------===//
1212

13+
#include "swift/Basic/ReferenceDependencyKeys.h"
1314
#include "swift/Basic/Statistic.h"
1415
#include "swift/Driver/DependencyGraph.h"
1516
#include "swift/Demangling/Demangle.h"
16-
#include "swift/Frontend/ReferenceDependencyKeys.h"
1717
#include "llvm/ADT/SmallString.h"
1818
#include "llvm/ADT/SmallVector.h"
1919
#include "llvm/ADT/StringSwitch.h"

lib/Driver/Driver.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include "swift/AST/DiagnosticsDriver.h"
2222
#include "swift/AST/DiagnosticsFrontend.h"
2323
#include "swift/Basic/LLVM.h"
24+
#include "swift/Basic/OutputFileMap.h"
2425
#include "swift/Basic/Range.h"
2526
#include "swift/Basic/Statistic.h"
2627
#include "swift/Basic/TaskQueue.h"
@@ -31,7 +32,6 @@
3132
#include "swift/Driver/Job.h"
3233
#include "swift/Driver/PrettyStackTrace.h"
3334
#include "swift/Driver/ToolChain.h"
34-
#include "swift/Frontend/OutputFileMap.h"
3535
#include "swift/Option/Options.h"
3636
#include "swift/Option/SanitizerOptions.h"
3737
#include "swift/Parse/Lexer.h"

lib/Driver/ToolChains.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
#include "swift/Basic/LLVM.h"
1717
#include "swift/Basic/Platform.h"
1818
#include "swift/Basic/Range.h"
19+
#include "swift/Basic/STLExtras.h"
1920
#include "swift/Basic/TaskQueue.h"
2021
#include "swift/Config.h"
2122
#include "swift/Driver/Compilation.h"
2223
#include "swift/Driver/Driver.h"
2324
#include "swift/Driver/Job.h"
24-
#include "swift/Frontend/Frontend.h"
2525
#include "swift/Option/Options.h"
2626
#include "clang/Basic/Version.h"
2727
#include "clang/Driver/Util.h"

lib/Driver/UnixToolChains.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
#include "swift/Driver/Compilation.h"
2222
#include "swift/Driver/Driver.h"
2323
#include "swift/Driver/Job.h"
24-
#include "swift/Frontend/Frontend.h"
2524
#include "swift/Option/Options.h"
2625
#include "clang/Basic/Version.h"
2726
#include "clang/Driver/Util.h"

lib/Driver/WindowsToolChains.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
#include "swift/Driver/Compilation.h"
2222
#include "swift/Driver/Driver.h"
2323
#include "swift/Driver/Job.h"
24-
#include "swift/Frontend/Frontend.h"
2524
#include "swift/Option/Options.h"
2625
#include "clang/Basic/Version.h"
2726
#include "clang/Driver/Util.h"

lib/Frontend/ArgsToFrontendOutputsConverter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
#include "ArgsToFrontendInputsConverter.h"
1515
#include "ArgsToFrontendOptionsConverter.h"
1616
#include "swift/AST/DiagnosticsFrontend.h"
17+
#include "swift/Basic/OutputFileMap.h"
1718
#include "swift/Basic/Platform.h"
1819
#include "swift/Frontend/Frontend.h"
19-
#include "swift/Frontend/OutputFileMap.h"
2020
#include "swift/Option/Options.h"
2121
#include "swift/Option/SanitizerOptions.h"
2222
#include "swift/Strings.h"

lib/Frontend/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ add_swift_library(swiftFrontend STATIC
77
Frontend.cpp
88
FrontendInputsAndOutputs.cpp
99
FrontendOptions.cpp
10-
OutputFileMap.cpp
1110
PrintingDiagnosticConsumer.cpp
1211
SerializedDiagnosticConsumer.cpp
1312
DEPENDS

lib/FrontendTool/ReferenceDependencies.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
#include "swift/AST/ReferencedNameTracker.h"
2424
#include "swift/AST/Types.h"
2525
#include "swift/Basic/LLVM.h"
26+
#include "swift/Basic/ReferenceDependencyKeys.h"
2627
#include "swift/Frontend/FrontendOptions.h"
27-
#include "swift/Frontend/ReferenceDependencyKeys.h"
2828
#include "llvm/ADT/MapVector.h"
2929
#include "llvm/ADT/SetVector.h"
3030
#include "llvm/ADT/SmallVector.h"

unittests/Driver/DependencyGraphTests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
#include "swift/Basic/ReferenceDependencyKeys.h"
12
#include "swift/Driver/DependencyGraph.h"
2-
#include "swift/Frontend/ReferenceDependencyKeys.h"
33
#include "gtest/gtest.h"
44

55
using namespace swift;

0 commit comments

Comments
 (0)