Eject before HTTP destroy

[elado]

Right now, when destroying an item, eject is called only after the HTTP is resolved.

In the UI, it'll update the list only after it was ejected. For a more responsive UI, eject can (optionally?) happen before destroy, same for create+inject.

[jmdobry]

I could work something out for eject and ejectAll, but for create the item doesn't have a primary key yet, so it can't be injected until it has one.

[elado]

In many cases the UI doesn't need to wait until the HTTP is done. Cases like <type> <enter> <type> <enter> <type> <enter> are common.

My suggestion is to manage a list of pending items:

Before create, mark the item as pending, inject without ID (or with a generated random ID).
After a successful HTTP request set the ID from the server, remove the pending flag.
After an error, mark as errored.

It brings more ideas that would help offline data, request queues and retries, but that's another subject.

[jmdobry]

Have your tried either of these?

// inject and eject emit events on $rootScope, can be configured to $emit, $broadcast, or none
$rootScope.$on('DS.eject', function ($event, resourceName, ejectedItem) {
  // ...
});

Or

// Emit events yourself
DS.defineResource({
  name: 'category',
  afterDestroy: function (resourceName, attrs, cb) {
    $rootScope.$broadcast('destroy', resourceName, attrs);
    cb(null, attrs);
  }
});

Edit: I meant to post this on #170

[elado]

Here's a POC for inject before create and eject before destroy: elado@a84c5c3

Tests are broken but this is just a start.
The intention is to inject a pending item (which also calls beforeInject/afterInject) and when HTTP request is done it's ejecting the pending item (without calling DS.eject) and injecting the new item (without calling before/afterInject).

Tested on my UI and it's way more responsive. It doesn't wait for the endpoint to response, so "type, enter, type, enter, type, enter" just works without delays.

Thoughs?

[elado]

Awesome!!! Thanks.