Skip to content

Allow highlight comments in json with jsonc-mode #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

kiennq
Copy link
Contributor

@kiennq kiennq commented Dec 11, 2019

Since lsp-mode now support json, we may want to add a new jsonc-mode that supports comment inside json file.
This change is based on disussion in #28

@kiennq
Copy link
Contributor Author

kiennq commented Dec 13, 2019

Friendly ping, can someone take a look at this?

@rememberYou
Copy link

@joshwnj could the merge be validated?

@yyoncho
Copy link

yyoncho commented Oct 9, 2020

ping

@it-is-wednesday
Copy link

Oh I need this. Pinging as well

@dustinlacewell
Copy link

.....?

@ext
Copy link

ext commented Sep 6, 2021

I would love to have this as well.

I find that it became more common in recent years and have decent support by libraries (possibly anecdotal, but at least the ones I tend to use).

@rememberYou
Copy link

Unfortunately, I doubt that this Pull Request will be merged soon. This package has not been maintained at all for over two years. Maybe a fork would be necessary or a new maintainer for this package...

@joshwnj
Copy link
Collaborator

joshwnj commented Oct 11, 2021

Hey all, sorry for the wait – life got busy :)

@joshwnj joshwnj merged commit 30c186c into json-emacs:master Oct 11, 2021
@rememberYou
Copy link

Since this is a feature that is in high demand, perhaps we could do a json-mode release to integrate it?

@joshwnj
Copy link
Collaborator

joshwnj commented Oct 13, 2021

@rememberYou thanks for the reminder. Released here: https://github.com/joshwnj/json-mode/releases/tag/v1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants