Merge pull request #758 from sirosen/hostname-format-check-empty-string

Julian · web-flow · commit dcdae5c02028 · 2025-01-30T07:56:32.000-05:00
test: hostname format check fails on empty string
diff --git a/tests/draft-next/optional/format/hostname.json b/tests/draft-next/optional/format/hostname.json
@@ -120,6 +120,11 @@
                 "description": "single label ending with digit",
                 "data": "hostnam3",
                 "valid": true
+            },
+            {
+                "description": "empty string",
+                "data": "",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft-next/optional/format/idn-hostname.json b/tests/draft-next/optional/format/idn-hostname.json
@@ -326,6 +326,11 @@
                 "description": "single label ending with digit",
                 "data": "hostnam3",
                 "valid": true
+            },
+            {
+                "description": "empty string",
+                "data": "",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft2019-09/optional/format/hostname.json b/tests/draft2019-09/optional/format/hostname.json
@@ -120,6 +120,11 @@
                 "description": "single label ending with digit",
                 "data": "hostnam3",
                 "valid": true
+            },
+            {
+                "description": "empty string",
+                "data": "",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft2019-09/optional/format/idn-hostname.json b/tests/draft2019-09/optional/format/idn-hostname.json
@@ -326,6 +326,11 @@
                 "description": "single label ending with digit",
                 "data": "hostnam3",
                 "valid": true
+            },
+            {
+                "description": "empty string",
+                "data": "",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft2020-12/optional/format/hostname.json b/tests/draft2020-12/optional/format/hostname.json
@@ -120,6 +120,11 @@
                 "description": "single label ending with digit",
                 "data": "hostnam3",
                 "valid": true
+            },
+            {
+                "description": "empty string",
+                "data": "",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft2020-12/optional/format/idn-hostname.json b/tests/draft2020-12/optional/format/idn-hostname.json
@@ -326,6 +326,11 @@
                 "description": "single label ending with digit",
                 "data": "hostnam3",
                 "valid": true
+            },
+            {
+                "description": "empty string",
+                "data": "",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft3/optional/format/host-name.json b/tests/draft3/optional/format/host-name.json
@@ -57,6 +57,11 @@
                 "description": "exceeds maximum label length",
                 "data": "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkl.com",
                 "valid": false
+            },
+            {
+                "description": "empty string",
+                "data": "",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft4/optional/format/hostname.json b/tests/draft4/optional/format/hostname.json
@@ -112,6 +112,11 @@
                 "description": "single label ending with digit",
                 "data": "hostnam3",
                 "valid": true
+            },
+            {
+                "description": "empty string",
+                "data": "",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft6/optional/format/hostname.json b/tests/draft6/optional/format/hostname.json
@@ -112,6 +112,11 @@
                 "description": "single label ending with digit",
                 "data": "hostnam3",
                 "valid": true
+            },
+            {
+                "description": "empty string",
+                "data": "",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft7/optional/format/hostname.json b/tests/draft7/optional/format/hostname.json
@@ -112,6 +112,11 @@
                 "description": "single label ending with digit",
                 "data": "hostnam3",
                 "valid": true
+            },
+            {
+                "description": "empty string",
+                "data": "",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft7/optional/format/idn-hostname.json b/tests/draft7/optional/format/idn-hostname.json
@@ -318,6 +318,11 @@
                 "description": "single label ending with digit",
                 "data": "hostnam3",
                 "valid": true
+            },
+            {
+                "description": "empty string",
+                "data": "",
+                "valid": false
             }
         ]
     }

Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,11 @@`
`120`	`120`	`"description": "single label ending with digit",`
`121`	`121`	`"data": "hostnam3",`
`122`	`122`	`"valid": true`
	`123`	`+ },`
	`124`	`+ {`
	`125`	`+ "description": "empty string",`
	`126`	`+ "data": "",`
	`127`	`+ "valid": false`
`123`	`128`	`}`
`124`	`129`	`]`
`125`	`130`	`}`
Original file line number	Diff line number	Diff line change
`@@ -326,6 +326,11 @@`
`326`	`326`	`"description": "single label ending with digit",`
`327`	`327`	`"data": "hostnam3",`
`328`	`328`	`"valid": true`
	`329`	`+ },`
	`330`	`+ {`
	`331`	`+ "description": "empty string",`
	`332`	`+ "data": "",`
	`333`	`+ "valid": false`
`329`	`334`	`}`
`330`	`335`	`]`
`331`	`336`	`}`
Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,11 @@`
`57`	`57`	`"description": "exceeds maximum label length",`
`58`	`58`	`"data": "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijkl.com",`
`59`	`59`	`"valid": false`
	`60`	`+ },`
	`61`	`+ {`
	`62`	`+ "description": "empty string",`
	`63`	`+ "data": "",`
	`64`	`+ "valid": false`
`60`	`65`	`}`
`61`	`66`	`]`
`62`	`67`	`}`
Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,11 @@`
`112`	`112`	`"description": "single label ending with digit",`
`113`	`113`	`"data": "hostnam3",`
`114`	`114`	`"valid": true`
	`115`	`+ },`
	`116`	`+ {`
	`117`	`+ "description": "empty string",`
	`118`	`+ "data": "",`
	`119`	`+ "valid": false`
`115`	`120`	`}`
`116`	`121`	`]`
`117`	`122`	`}`
Original file line number	Diff line number	Diff line change
`@@ -318,6 +318,11 @@`
`318`	`318`	`"description": "single label ending with digit",`
`319`	`319`	`"data": "hostnam3",`
`320`	`320`	`"valid": true`
	`321`	`+ },`
	`322`	`+ {`
	`323`	`+ "description": "empty string",`
	`324`	`+ "data": "",`
	`325`	`+ "valid": false`
`321`	`326`	`}`
`322`	`327`	`]`
`323`	`328`	`}`