add tests to validate existing exception hierarchy, in preparation for adjustment. add \RuntimeException wrapper. update all extensions of \RuntimeException to extend the wrapper. spl-exception wrappers now implement a common exception interface for this package. this allows consumers to handle all custom exception types thrown by catching the common interface rather than by catching each specific extension or their spl parents.

Author: abacaphiliac

src/JsonSchema/Constraints/ConstraintInterface.php

@@ -55,6 +55,7 @@ public function isValid();
      * @param mixed $schema
      * @param mixed $path
      * @param mixed $i
+     * @throws \JsonSchema\Exception\ExceptionInterface
      */
     public function check($value, $schema = null, $path = null, $i = null);
 }

src/JsonSchema/Exception/ExceptionInterface.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace JsonSchema\Exception;
+
+interface ExceptionInterface
+{
+
+}

src/JsonSchema/Exception/InvalidArgumentException.php

@@ -12,6 +12,6 @@
 /**
  * Wrapper for the InvalidArgumentException
  */
-class InvalidArgumentException extends \InvalidArgumentException
+class InvalidArgumentException extends \InvalidArgumentException implements ExceptionInterface
 {
 }

src/JsonSchema/Exception/InvalidSchemaMediaTypeException.php

@@ -12,6 +12,6 @@
 /**
  * Wrapper for the InvalidSchemaMediaType
  */
-class InvalidSchemaMediaTypeException extends \RuntimeException
+class InvalidSchemaMediaTypeException extends RuntimeException
 {    
 }

src/JsonSchema/Exception/JsonDecodingException.php

@@ -12,7 +12,7 @@
 /**
  * Wrapper for the JsonDecodingException
  */
-class JsonDecodingException extends \RuntimeException
+class JsonDecodingException extends RuntimeException
 {
     public function __construct($code = JSON_ERROR_NONE, \Exception $previous = null)
     {

src/JsonSchema/Exception/ResourceNotFoundException.php

@@ -12,6 +12,6 @@
 /**
  * Wrapper for the ResourceNotFoundException
  */
-class ResourceNotFoundException extends \RuntimeException
+class ResourceNotFoundException extends RuntimeException
 {
 }

src/JsonSchema/Exception/RuntimeException.php

@@ -0,0 +1,17 @@
+<?php
+
+/*
+ * This file is part of the JsonSchema package.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace JsonSchema\Exception;
+
+/**
+ * Wrapper for the RuntimeException
+ */
+class RuntimeException extends \RuntimeException implements ExceptionInterface
+{
+}

src/JsonSchema/Exception/UnresolvableJsonPointerException.php

@@ -13,6 +13,6 @@
  * @package JsonSchema\Exception
  * @author Joost Nijhuis <[email protected]>
  */
-class UnresolvableJsonPointerException extends \InvalidArgumentException
+class UnresolvableJsonPointerException extends InvalidArgumentException
 {
 }

src/JsonSchema/Exception/UriResolverException.php

@@ -12,6 +12,6 @@
 /**
  * Wrapper for the UriResolverException
  */
-class UriResolverException extends \RuntimeException
+class UriResolverException extends RuntimeException
 {
 }

tests/Exception/InvalidArgumentExceptionTest.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace JsonSchema\Tests\Exception;
+
+use JsonSchema\Exception\InvalidArgumentException;
+
+class InvalidArgumentExceptionTest extends \PHPUnit_Framework_TestCase
+{
+    public function testHierarchy()
+    {
+        $exception = new InvalidArgumentException();
+        self::assertInstanceOf('\InvalidArgumentException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+    }
+}

tests/Exception/InvalidSchemaMediaTypeExceptionTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace JsonSchema\Tests\Exception;
+
+use JsonSchema\Exception\InvalidSchemaMediaTypeException;
+
+class InvalidSchemaMediaTypeExceptionTest extends \PHPUnit_Framework_TestCase
+{
+    public function testHierarchy()
+    {
+        $exception = new InvalidSchemaMediaTypeException();
+        self::assertInstanceOf('\RuntimeException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+    }
+}

tests/Exception/InvalidSourceUriExceptionTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace JsonSchema\Tests\Exception;
+
+use JsonSchema\Exception\InvalidSourceUriException;
+
+class InvalidSourceUriExceptionTest extends \PHPUnit_Framework_TestCase
+{
+    public function testHierarchy()
+    {
+        $exception = new InvalidSourceUriException();
+        self::assertInstanceOf('\InvalidArgumentException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\InvalidArgumentException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+    }
+}

tests/Exception/JsonDecodingExceptionTest.php

@@ -0,0 +1,88 @@
+<?php
+
+namespace JsonSchema\Tests\Exception;
+
+use JsonSchema\Exception\JsonDecodingException;
+
+class JsonDecodingExceptionTest extends \PHPUnit_Framework_TestCase
+{
+    public function testHierarchy()
+    {
+        $exception = new JsonDecodingException();
+        self::assertInstanceOf('\RuntimeException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+    }
+    
+    public function testDefaultMessage()
+    {
+        $exception = new JsonDecodingException();
+        self::assertNotEmpty($exception->getMessage());
+    }
+    
+    public function testErrorNoneMessage()
+    {
+        $exception = new JsonDecodingException(JSON_ERROR_NONE);
+        self::assertNotEmpty($exception->getMessage());
+    }
+    
+    public function testErrorDepthMessage()
+    {
+        $exception = new JsonDecodingException(JSON_ERROR_DEPTH);
+        self::assertNotEmpty($exception->getMessage());
+    }
+    
+    public function testErrorStateMismatchMessage()
+    {
+        $exception = new JsonDecodingException(JSON_ERROR_STATE_MISMATCH);
+        self::assertNotEmpty($exception->getMessage());
+    }
+    
+    public function testErrorControlCharacterMessage()
+    {
+        $exception = new JsonDecodingException(JSON_ERROR_CTRL_CHAR);
+        self::assertNotEmpty($exception->getMessage());
+    }
+    
+    public function testErrorUtf8Message()
+    {
+        $exception = new JsonDecodingException(JSON_ERROR_UTF8);
+        self::assertNotEmpty($exception->getMessage());
+    }
+    
+    public function testErrorSyntaxMessage()
+    {
+        $exception = new JsonDecodingException(JSON_ERROR_SYNTAX);
+        self::assertNotEmpty($exception->getMessage());
+    }
+    
+    public function testErrorInfiniteOrNotANumberMessage()
+    {
+        if (!defined('JSON_ERROR_INF_OR_NAN')) {
+            self::markTestSkipped('JSON_ERROR_INF_OR_NAN is not defined until php55.');
+        }
+        
+        $exception = new JsonDecodingException(JSON_ERROR_INF_OR_NAN);
+        self::assertNotEmpty($exception->getMessage());
+    }
+    
+    public function testErrorRecursionMessage()
+    {
+        if (!defined('JSON_ERROR_RECURSION')) {
+            self::markTestSkipped('JSON_ERROR_RECURSION is not defined until php55.');
+        }
+
+        $exception = new JsonDecodingException(JSON_ERROR_RECURSION);
+        self::assertNotEmpty($exception->getMessage());
+    }
+    
+    public function testErrorUnsupportedTypeMessage()
+    {
+        if (!defined('JSON_ERROR_UNSUPPORTED_TYPE')) {
+            self::markTestSkipped('JSON_ERROR_UNSUPPORTED_TYPE is not defined until php55.');
+        }
+
+        $exception = new JsonDecodingException(JSON_ERROR_UNSUPPORTED_TYPE);
+        self::assertNotEmpty($exception->getMessage());
+    }
+}

tests/Exception/ResourceNotFoundExceptionTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace JsonSchema\Tests\Exception;
+
+use JsonSchema\Exception\ResourceNotFoundException;
+
+class ResourceNotFoundExceptionTest extends \PHPUnit_Framework_TestCase
+{
+    public function testHierarchy()
+    {
+        $exception = new ResourceNotFoundException();
+        self::assertInstanceOf('\RuntimeException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+    }
+}

tests/Exception/RuntimeExceptionTest.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace JsonSchema\Tests\Exception;
+
+use JsonSchema\Exception\RuntimeException;
+
+class RuntimeExceptionTest extends \PHPUnit_Framework_TestCase
+{
+    public function testHierarchy()
+    {
+        $exception = new RuntimeException();
+        self::assertInstanceOf('\RuntimeException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+    }
+}

tests/Exception/UnresolvableJsonPointerExceptionTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace JsonSchema\Tests\Exception;
+
+use JsonSchema\Exception\UnresolvableJsonPointerException;
+
+class UnresolvableJsonPointerExceptionTest extends \PHPUnit_Framework_TestCase
+{
+    public function testHierarchy()
+    {
+        $exception = new UnresolvableJsonPointerException();
+        self::assertInstanceOf('\InvalidArgumentException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\InvalidArgumentException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+    }
+}

tests/Exception/UriResolverExceptionTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace JsonSchema\Tests\Exception;
+
+use JsonSchema\Exception\UriResolverException;
+
+class UriResolverExceptionTest extends \PHPUnit_Framework_TestCase
+{
+    public function testHierarchy()
+    {
+        $exception = new UriResolverException();
+        self::assertInstanceOf('\RuntimeException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception);
+        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+    }
+}