fix: Array with number values with mathematical equality are considered valid

Author: DannyvdSluijs

src/JsonSchema/Tool/DeepComparer.php

@@ -17,9 +17,18 @@ public static function isEqual($left, $right): bool
         }
 
         $isLeftScalar = is_scalar($left);
+        $isLeftNumber = is_int($left) || is_float($left);
         $isRightScalar = is_scalar($right);
+        $isRightNumber = is_int($right) || is_float($right);
 
         if ($isLeftScalar && $isRightScalar) {
+            /**
+             * In Json-Schema mathematically equal numbers are compared equal
+             **/
+            if ($isLeftNumber && $isRightNumber && (float) $left === (float) $right) {
+                return true;
+            }
+
             return $left === $right;
         }
 

tests/Constraints/ConstTest.php

@@ -17,7 +17,7 @@ class ConstTest extends BaseTestCase
     public function getInvalidTests(): array
     {
         return [
-            [
+            'Object with inner string value' => [
                 '{"value":"foo"}',
                 '{
                   "type":"object",
@@ -27,7 +27,7 @@ public function getInvalidTests(): array
                   "additionalProperties":false
                 }'
             ],
-            [
+            'Object with inner integer value' => [
                 '{"value":5}',
                 '{
                   "type":"object",
@@ -37,7 +37,7 @@ public function getInvalidTests(): array
                   "additionalProperties":false
                 }'
             ],
-            [
+            'Object with inner boolean value' => [
                 '{"value":false}',
                 '{
                   "type":"object",
@@ -47,7 +47,7 @@ public function getInvalidTests(): array
                   "additionalProperties":false
                 }'
             ],
-            [
+            'Object with inner numerical string value' => [
                 '{
                     "value": {
                         "foo": "12"
@@ -71,7 +71,7 @@ public function getInvalidTests(): array
     public function getValidTests(): array
     {
         return [
-            [
+            'String value' => [
                 '{"value":"bar"}',
                 '{
                   "type":"object",
@@ -81,7 +81,7 @@ public function getValidTests(): array
                   "additionalProperties":false
                 }'
             ],
-            [
+            'Boolean(false) value' => [
                 '{"value":false}',
                 '{
                   "type":"object",
@@ -91,7 +91,7 @@ public function getValidTests(): array
                   "additionalProperties":false
                 }'
             ],
-            [
+            'Boolean(true) value' => [
                 '{"value":true}',
                 '{
                   "type":"object",
@@ -101,7 +101,7 @@ public function getValidTests(): array
                   "additionalProperties":false
                 }'
             ],
-            [
+            'Integer value' => [
                 '{"value":5}',
                 '{
                   "type":"object",
@@ -111,7 +111,7 @@ public function getValidTests(): array
                   "additionalProperties":false
                 }'
             ],
-            [
+            'Object with inner integer value' => [
                 '{
                     "value": {
                         "foo": 12

tests/Constraints/EnumTest.php

@@ -176,14 +176,22 @@ public function getValidTests(): array
                     }
                 }'
             ],
-            'Numeric values with mathematical equality are considered valid' => [
+            'Number values with mathematical equality are considered valid' => [
                 'data' => '12',
                 'schema' => '{
                     "type": "any",
                     "enum": [
                         12.0
                     ]
                 }'
+            ],
+            'Array with number values with mathematical equality are considered valid' => [
+                'input' => '[ 0.0 ]',
+                'schema' => '{
+                    "enum": [
+                        [ 0 ]
+                    ]
+                }',
             ]
         ];
     }