Skip to content

Commit 4f96ab3

Browse files
committed
avoid unnessary array_merge calls
1 parent 2128f9d commit 4f96ab3

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

src/JsonSchema/Constraints/Constraint.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,9 @@ public function addError(JsonPointer $path = null, $message, $constraint='', arr
123123
*/
124124
public function addErrors(array $errors)
125125
{
126-
$this->errors = array_merge($this->errors, $errors);
126+
if ($errors) {
127+
$this->errors = array_merge($this->errors, $errors);
128+
}
127129
}
128130

129131
/**

src/JsonSchema/Constraints/Factory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public function setConstraintClass($name, $class)
128128
*/
129129
public function createInstanceFor($constraintName)
130130
{
131-
if (array_key_exists($constraintName, $this->constraintMap)) {
131+
if (isset($this->constraintMap[$constraintName])) {
132132
if (!isset($this->instanceCache[$constraintName])) {
133133
$this->instanceCache[$constraintName] = new $this->constraintMap[$constraintName](
134134
$this->checkMode,

src/JsonSchema/Validator.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
namespace JsonSchema;
1111

12-
use JsonSchema\Constraints\SchemaConstraint;
1312
use JsonSchema\Constraints\Constraint;
1413
use JsonSchema\Entity\JsonPointer;
1514

0 commit comments

Comments
 (0)