Allow title and aria-label attributes in the anchor-has-content rule

Author: gorohash

__tests__/src/rules/anchor-has-content-test.js

@@ -32,10 +32,13 @@ ruleTester.run('anchor-has-content', rule, {
     { code: '<a>{foo.bar}</a>' },
     { code: '<a dangerouslySetInnerHTML={{ __html: "foo" }} />' },
     { code: '<a children={children} />' },
+    { code: '<a title={title} aria-label={ariaLabel} />' },
   ].map(parserOptionsMapper),
   invalid: [
     { code: '<a />', errors: [expectedError] },
     { code: '<a><Bar aria-hidden /></a>', errors: [expectedError] },
     { code: '<a>{undefined}</a>', errors: [expectedError] },
+    { code: '<a title={title} />', errors: [expectedError] },
+    { code: '<a aria-label={ariaLabel} />', errors: [expectedError] },
   ].map(parserOptionsMapper),
 });

docs/rules/anchor-has-content.md

@@ -2,6 +2,8 @@
 
 Enforce that anchors have content and that the content is accessible to screen readers. Accessible means that it is not hidden using the `aria-hidden` prop. Refer to the references to learn about why this is important.
 
+Alternatively, you may use the `title` and `aria-label` props.
+
 ## Rule details
 
 This rule takes one optional object argument of type object:
@@ -41,6 +43,7 @@ return (
 <a>Anchor Content!</a>
 <a><TextWrapper /><a>
 <a dangerouslySetInnerHTML={{ __html: 'foo' }} />
+<a title='foo' aria-label='foo' />
 ```
 
 ### Fail

src/rules/anchor-has-content.js

@@ -7,7 +7,7 @@
 // Rule Definition
 // ----------------------------------------------------------------------------
 
-import { elementType } from 'jsx-ast-utils';
+import { elementType, hasEveryProp } from 'jsx-ast-utils';
 import { arraySchema, generateObjSchema } from '../util/schemas';
 import hasAccessibleChild from '../util/hasAccessibleChild';
 
@@ -37,6 +37,9 @@ module.exports = {
       if (hasAccessibleChild(node.parent)) {
         return;
       }
+      if (hasEveryProp(node.attributes, ['title', 'aria-label'])) {
+        return;
+      }
 
       context.report({
         node,