Add warning when association not fully created for Role and NIC

Author: Ed Munoz

src/ServiceManagement/Network/Commands.Network/NetworkSecurityGroup/Association/GetAzureNetworkSecurityGroupAssociation.cs

@@ -80,16 +80,16 @@ public class GetAzureNetworkSecurityGroupAssociation : NetworkCmdletBase
         public override void ExecuteCmdlet()
         {
             NetworkSecurityGroupGetAssociationResponse assocResponse = null;
+            string warningAssociationNotFullyCrated = null;
             if (string.Equals(this.ParameterSetName, GetNetworkSecurityGroupAssociationForSubnet))
             {
                 assocResponse = Client.GetNetworkSecurityGroupForSubnet(VirtualNetworkName, SubnetName);
 
-                if (assocResponse.State != "Created")
-                {
-                    WriteWarningWithTimestamp(
-                        string.Format(Resources.NetworkSecurityGroupNotActiveInSubnet, assocResponse.Name, VirtualNetworkName, SubnetName));
-
-                }
+                warningAssociationNotFullyCrated = string.Format(
+                    Resources.NetworkSecurityGroupNotActiveInSubnet,
+                    assocResponse.Name,
+                    VirtualNetworkName,
+                    SubnetName);
             }
             else
             {
@@ -105,6 +105,12 @@ public override void ExecuteCmdlet()
                         this.ServiceName,
                         this.obtainedDeploymentName,
                         this.RoleName);
+
+                    warningAssociationNotFullyCrated = string.Format(
+                        Resources.NetworkSecurityGroupNotActiveInRole,
+                        this.ServiceName,
+                        this.obtainedDeploymentName,
+                        this.RoleName);
                 }
                 else
                 {
@@ -113,9 +119,21 @@ public override void ExecuteCmdlet()
                         this.obtainedDeploymentName,
                         this.RoleName,
                         this.NetworkInterfaceName);
+
+                    warningAssociationNotFullyCrated = string.Format(
+                        Resources.NetworkSecurityGroupNotActiveInNIC,
+                        this.ServiceName,
+                        this.obtainedDeploymentName,
+                        this.RoleName,
+                        this.NetworkInterfaceName);
                 }
             }
 
+            if (assocResponse.State != "Created")
+            {
+                WriteWarningWithTimestamp(warningAssociationNotFullyCrated);
+            }
+
             INetworkSecurityGroup securityGroup = Client.GetNetworkSecurityGroup(assocResponse.Name, Detailed);
             WriteObject(securityGroup);
         }

src/ServiceManagement/Network/Commands.Network/Properties/Resources.Designer.cs

@@ -294,4 +294,10 @@
   <data name="SetNSGSubnetAssociationTarget" xml:space="preserve">
     <value>Network Security Group "{0}", Virtual Network: "{1}", Subnet "{2}"</value>
   </data>
+  <data name="NetworkSecurityGroupNotActiveInNIC" xml:space="preserve">
+    <value>Network SecurityGroup "{0}" is not active in cloud service "{1}", deployment "{2}", role "{3}", network interface "{4}".</value>
+  </data>
+  <data name="NetworkSecurityGroupNotActiveInRole" xml:space="preserve">
+    <value>Network SecurityGroup "{0}" is not active in cloud service "{1}", deployment "{2}", role "{3}".</value>
+  </data>
 </root>