changing the check if parameter has been populated

Author: ayeletshpigelman

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/AuditingTests.ps1

@@ -942,6 +942,14 @@ function Test-BlobAuditingOnDatabase
 		Assert-AreEqual $policy.RetentionInDays 8
 		Assert-True { $policy.StorageKeyType -eq  "Secondary"}
 
+		# Test	- Tests the option to remove all audit action and audit action groups
+		Set-AzureRmSqlDatabaseAuditingPolicy -AuditType Blob -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -AuditActionGroup @() -AuditAction @()
+		$policy = Get-AzureRmSqlDatabaseAuditingPolicy -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName
+
+		# Assert
+		Assert-AreEqual $policy.AuditState "Enabled"
+		Assert-AreEqual $policy.AuditActionGroup.Length 0
+		Assert-AreEqual $policy.AuditAction.Length 0
 
 		# Test
 		Remove-AzureRmSqlDatabaseAuditing -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName

src/ResourceManager/Sql/Commands.Sql/Auditing/Cmdlet/SetAzureSqlDatabaseAuditingPolicy.cs

@@ -45,14 +45,14 @@ public class SetAzureSqlDatabaseAuditingPolicy : SqlDatabaseAuditingCmdletBase
         ///  Defines the set of audit action groups that would be used by the auditing settings
         /// </summary>
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The set of the audit action groups")]
-        [ValidateNotNullOrEmpty]
+        [ValidateNotNull]
         public AuditActionGroups[] AuditActionGroup { get; set; }
 
         /// <summary>
         ///  Defines the set of audit actions that would be used by the auditing settings
         /// </summary>
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The set of the audit actions")]
-        [ValidateNotNullOrEmpty]
+        [ValidateNotNull]
         public string[] AuditAction { get; set; }
 
         /// <summary>

src/ResourceManager/Sql/Commands.Sql/Auditing/Cmdlet/SetAzureSqlServerAuditingPolicy.cs

@@ -40,7 +40,7 @@ public class SetAzureSqlServerAuditingPolicy : SqlDatabaseServerAuditingCmdletBa
         ///  Defines the set of audit action groups that would be used by the auditing settings
         /// </summary>
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The set of the audit action groups")]
-        [ValidateNotNullOrEmpty]
+        [ValidateNotNull]
         public AuditActionGroups[] AuditActionGroup { get; set; }
 
         [Parameter(Mandatory = false)]

src/ResourceManager/Sql/Commands.Sql/Auditing/Cmdlet/SqlDatabaseAuditingCmdletBase.cs

@@ -33,7 +33,7 @@ public abstract class SqlDatabaseAuditingCmdletBase : AzureSqlDatabaseCmdletBase
         /// <returns>A model object</returns>
         protected override AuditingPolicyModel GetEntity()
         {
-            if (AuditType == AuditType.NotSet)
+            if (!MyInvocation.BoundParameters.ContainsKey(SecurityConstants.AuditType))
             {
                 AuditType = AuditType.Blob;
                 var blobPolicy = GetEntityHelper();

src/ResourceManager/Sql/Commands.Sql/Auditing/Cmdlet/SqlDatabaseServerAuditingCmdletBase.cs

@@ -40,7 +40,7 @@ public abstract class SqlDatabaseServerAuditingCmdletBase : AzureSqlCmdletBase<A
         /// <returns>A model object</returns>
         protected override AuditingPolicyModel GetEntity()
         {
-            if (AuditType == AuditType.NotSet)
+            if (!MyInvocation.BoundParameters.ContainsKey(SecurityConstants.AuditType))
             {
                 AuditType = AuditType.Blob;
                 var blobPolicy = GetEntityHelper();

src/ResourceManager/Sql/Commands.Sql/Auditing/Model/AuditingPolicyModel.cs

@@ -26,9 +26,8 @@ public enum AuditStateType { Enabled, Disabled, New };
 
     /// <summary>
     /// The possible values of auditing type. 
-    /// NotSet is a temporary value in order to mark that AuditType parameter was not provided at all by the user. It is only initial value, and won't be returned to the user.
     /// </summary>
-    public enum AuditType { NotSet, Table, Blob };
+    public enum AuditType { Table, Blob };
 
     /// <summary>
     /// The base class that defines the core properties of an auditing policy

src/ResourceManager/Sql/Commands.Sql/Common/SecurityConstants.cs

@@ -34,14 +34,17 @@ public class SecurityConstants
         public const string Login_Failure = "Login_Failure";
         public const string TransactionManagement_Success = "TransactionManagement_Success";
         public const string TransactionManagement_Failure = "TransactionManagement_Failure";
+
+        public const string All = "All";
+        public const string None = "None";
+
+        // Parameters Names:
+        public const string AuditType = "AuditType";
         public const string StorageKeyType = "StorageKeyType";
         public const string EventType = "EventType";
         public const string AuditActionGroup = "AuditActionGroup";
         public const string AuditAction = "AuditAction";
 
-        public const string All = "All";
-        public const string None = "None";
-
         public static readonly Dictionary<string, AuditEventType> AuditEventsToAuditEventType = new Dictionary
             <string, AuditEventType>
         {