Rename the "windowsCredential" to "Crendential" in New-AzureDataFactoryEncryptValue, and update the description of this parameter in the help content according to the latest string from UE

Author: jtlibingus

src/ResourceManager/DataFactories/Commands.DataFactories.Test/UnitTests/NewDataFactoryEncryptValueTests.cs

@@ -66,7 +66,7 @@ public void TestOnPremDatasourceEncryptionWinAuth()
             string expectedOutput = "My encrypted string " + Guid.NewGuid();
             string winAuthUserName = "foo";
             SecureString winAuthPassword = new SecureString();
-            PSCredential windowsCredential = new PSCredential(winAuthUserName, winAuthPassword);
+            PSCredential credential = new PSCredential(winAuthUserName, winAuthPassword);
 
             var cmdlet = new NewAzureDataFactoryEncryptValueCommand
             {
@@ -76,17 +76,17 @@ public void TestOnPremDatasourceEncryptionWinAuth()
                 ResourceGroupName = ResourceGroupName,
                 DataFactoryName = DataFactoryName,
                 GatewayName = GatewayName,
-                WindowsCredential = windowsCredential
+                Credential = credential
             };
 
             // Arrange
-            this.dataFactoriesClientMock.Setup(f => f.OnPremisesEncryptString(secureString, ResourceGroupName, DataFactoryName, GatewayName, windowsCredential)).Returns(expectedOutput);
+            this.dataFactoriesClientMock.Setup(f => f.OnPremisesEncryptString(secureString, ResourceGroupName, DataFactoryName, GatewayName, credential)).Returns(expectedOutput);
 
             // Action
             cmdlet.ExecuteCmdlet();
 
             // Assert
-            this.dataFactoriesClientMock.Verify(f => f.OnPremisesEncryptString(secureString, ResourceGroupName, DataFactoryName, GatewayName, windowsCredential), Times.Once());
+            this.dataFactoriesClientMock.Verify(f => f.OnPremisesEncryptString(secureString, ResourceGroupName, DataFactoryName, GatewayName, credential), Times.Once());
             this.commandRuntimeMock.Verify(f => f.WriteObject(expectedOutput), Times.Once());
         }
     }

src/ResourceManager/DataFactories/Commands.DataFactories/Encrypt/NewAzureDataFactoryEncryptValueCommand.cs

@@ -45,7 +45,7 @@ public class NewAzureDataFactoryEncryptValueCommand : DataFactoryBaseCmdlet
 
         [Parameter(ParameterSetName = ByFactoryObject, Position = 3, Mandatory = false, HelpMessage = "The windows authentication credential.")]
         [Parameter(ParameterSetName = ByFactoryName, Position = 4, Mandatory = false, HelpMessage = "The windows authentication credential.")]
-        public PSCredential WindowsCredential { get; set; }
+        public PSCredential Credential { get; set; }
 
         [EnvironmentPermission(SecurityAction.Demand, Unrestricted = true)]
         public override void ExecuteCmdlet()
@@ -72,7 +72,7 @@ public override void ExecuteCmdlet()
             else
             {
                 // On-premises encryption with Gateway
-                encryptedValue = DataFactoryClient.OnPremisesEncryptString(Value, ResourceGroupName, DataFactoryName, GatewayName, WindowsCredential);
+                encryptedValue = DataFactoryClient.OnPremisesEncryptString(Value, ResourceGroupName, DataFactoryName, GatewayName, Credential);
             }
 
             WriteObject(encryptedValue);

src/ResourceManager/DataFactories/Commands.DataFactories/Microsoft.Azure.Commands.DataFactories.dll-Help.xml

@@ -2082,9 +2082,9 @@
           <command:parameterValue required="true" variableLength="false">String</command:parameterValue>
         </command:parameter>
         <command:parameter required="false" variableLength="false" globbing="false" pipelineInput="false" position="4" aliases="">
-          <maml:name>WindowsCredential</maml:name>
+          <maml:name>Credential</maml:name>
           <maml:description>
-            <maml:para>Specifies the windows authentication credential user name and password. This cmdlet encrypts the credential data that this parameter specifies.</maml:para>
+            <maml:para>Specifies the Windows authentication credentials (user name and password) to be used. This cmdlet encrypts the credential data you specify here.</maml:para>
           </maml:description>
           <command:parameterValue required="true" variableLength="false">PSCredential</command:parameterValue>
         </command:parameter>
@@ -2120,9 +2120,9 @@
           <command:parameterValue required="true" variableLength="false">String</command:parameterValue>
         </command:parameter>
         <command:parameter required="false" variableLength="false" globbing="false" pipelineInput="false" position="5" aliases="">
-          <maml:name>WindowsCredential</maml:name>
+          <maml:name>Credential</maml:name>
           <maml:description>
-            <maml:para>Specifies the windows authentication credential user name and password. This cmdlet encrypts the credential data that this parameter specifies.</maml:para>
+            <maml:para>Specifies the Windows authentication credentials (user name and password) to be used. This cmdlet encrypts the credential data you specify here.</maml:para>
           </maml:description>
           <command:parameterValue required="true" variableLength="false">PSCredential</command:parameterValue>
         </command:parameter>
@@ -2190,9 +2190,9 @@
         <dev:defaultValue></dev:defaultValue>
       </command:parameter>
       <command:parameter required="true" variableLength="false" globbing="false" pipelineInput="false" position="5" aliases="">
-        <maml:name>WindowsCredential</maml:name>
+        <maml:name>Credential</maml:name>
         <maml:description>
-          <maml:para>Specifies the windows authentication credential user name and password. This cmdlet encrypts the credential data that this parameter specifies.</maml:para>
+          <maml:para>Specifies the Windows authentication credentials (user name and password) to be used. This cmdlet encrypts the credential data you specify here.</maml:para>
         </maml:description>
         <command:parameterValue required="true" variableLength="false">PSCredential</command:parameterValue>
         <dev:type>
@@ -2277,7 +2277,7 @@
         <dev:code>
           PS C:\&gt; $Value = ConvertTo-SecureString "Data Source=ContosoServer;Initial Catalog=catelog;Integrated Security=True" -AsPlainText -Force
           PS C:\&gt; $Credential = Get-Credential
-          PS C:\&gt; New-AzureDataFactoryEncryptValue -DataFactoryName "UncycloADF" -GatewayName "UncycloGateway" -ResourceGroupName "ADF" -Value $Value -WindowsCredential $Credential
+          PS C:\&gt; New-AzureDataFactoryEncryptValue -DataFactoryName "UncycloADF" -GatewayName "UncycloGateway" -ResourceGroupName "ADF" -Value $Value -Credential $Credential
           data source=ContosoServer;initial catalog=catelog;EncryptedCredential=KAAAAAABAAAQAAAAQUU5MUVBNzY4QkFCQkI3MEUwRTMxOUNFNkM0MjRDOTVDNDk3RTcyRi8XAXyE/H+f3JydTkdg5t2g1eC/VtyF3NAD3idYnhrAphPJmO0pCaG5nH2IY48L3XJi7wabrlrGF+ieiWh1bwdgdxrW+t2jWPnLvT/ENUXtcevpx/dmTGKagH8TU9HLcoL1CAanb7Vkpga1B/uzRxBnVdsdtfvBzxG2M810tj1WzL8lFzA1mO5GbB0+ge116y0scL1vxjerjl5Muv0r0scG3lhj+IF0sXUMITFvhQwOIqweR052E6JlfJu+mTNFLCCkpw1iV+rhRhKqJF752dBuWjzI1EoyQUE17oK4OevkquuhUbfJmzj9BhGKQ+VkndAZiSw19FEGSC7JzoUe/XWEs/FJYrQCCXIeNS94J9/VzN6KPYJR1pzAYCtnhq+p8Q==
         </dev:code>
         <dev:remarks>

src/ResourceManager/DataFactories/Commands.DataFactories/Models/DataFactoryClient.Encrypt.cs

@@ -33,7 +33,7 @@ public virtual string CloudEncryptString(SecureString value, string resourceGrou
                 resourceGroupName, dataFactoryName);
         }
 
-        public virtual string OnPremisesEncryptString(SecureString value, string resourceGroupName, string dataFactoryName, string gatewayName, PSCredential windowsCredential)
+        public virtual string OnPremisesEncryptString(SecureString value, string resourceGroupName, string dataFactoryName, string gatewayName, PSCredential credential)
         {
             if (value == null)
             {
@@ -52,8 +52,8 @@ public virtual string OnPremisesEncryptString(SecureString value, string resourc
                         }
                 };
 
-            string userName = windowsCredential != null ? windowsCredential.UserName : null;
-            SecureString password = windowsCredential != null ? windowsCredential.Password : null;
+            string userName = credential != null ? credential.UserName : null;
+            SecureString password = credential != null ? credential.Password : null;
             UserInputConnectionString connectionString = new UserInputConnectionString(value, userName, password);
             var gatewayEncryptionClient = new GatewayEncryptionClient();
             return gatewayEncryptionClient.Encrypt(connectionString, gatewayEncryptionInfos);