Skip to content

Commit 6131ba9

Browse files
author
begoldsm
committed
Address PR feedback.
1 parent e436766 commit 6131ba9

File tree

5 files changed

+21
-4
lines changed

5 files changed

+21
-4
lines changed

src/ResourceManager/DataLakeAnalytics/ChangeLog.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@
1818
- Additional information about change #1
1919
-->
2020
## Current Release
21+
* Update Get-AdlJob to support Top parameter
22+
* Update Get-AdlJob to return the list of jobs in order by most recently submitted
23+
* Updated help for all cmdlets to include output as well as more descriptions of parameters and the inclusion of aliases.
24+
* Update New-AdlAnalyticsAccount and Set-AdlAnalyticsAccount to support commitment tier options for the service.
25+
* Added OutputType mismatch warnings to all cmdlets with incorrect OutputType attributes. These will be fixed in a future breaking change release.
2126

2227
## Version 2.4.0
2328
* Removal of unsupported parameters in Add and Set-AzureRMDataLakeAnalyticsDataSource (default for data lake store)

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands/GetAzureRmDataLakeAnalyticsJob.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ public class GetAzureDataLakeAnalyticsJob : DataLakeAnalyticsCmdletBase
9090
[Parameter(ParameterSetName = BaseParameterSetName, ValueFromPipelineByPropertyName = true,
9191
Mandatory = false, HelpMessage = "An optional value which indicates the number of jobs to return. Default value is 500")]
9292
[ValidateNotNullOrEmpty]
93-
9493
public int? Top { get; set; }
9594

9695
public override void ExecuteCmdlet()

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands/SetAzureRmDataLakeAnalyticsCatalogSecret.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,10 @@ public override void ExecuteCmdlet()
7373

7474
var toUse = Uri ?? new Uri(string.Format("https://{0}:{1}", DatabaseHost, Port));
7575

76-
DataLakeAnalyticsClient.UpdateSecret(Account, DatabaseName, Secret.UserName,
77-
Secret.GetNetworkCredential().Password, toUse.AbsoluteUri);
76+
// TODO: Remove the WriteObject during next breaking change release, since this object
77+
// is always null.
78+
WriteObject(DataLakeAnalyticsClient.UpdateSecret(Account, DatabaseName, Secret.UserName,
79+
Secret.GetNetworkCredential().Password, toUse.AbsoluteUri));
7880
}
7981
}
8082
}

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Models/DataLakeAnalyticsClient.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ public void CreateSecret(string accountName, string databaseName,
411411
});
412412
}
413413

414-
public void UpdateSecret(string accountName, string databaseName,
414+
public USqlSecret UpdateSecret(string accountName, string databaseName,
415415
string secretName, string password, string hostUri)
416416
{
417417
_catalogClient.Catalog.UpdateSecret(accountName, databaseName, secretName,
@@ -420,6 +420,9 @@ public void UpdateSecret(string accountName, string databaseName,
420420
Password = password,
421421
Uri = hostUri
422422
});
423+
424+
// TODO: Remove this during the next breaking change release.
425+
return null;
423426
}
424427

425428
public void DeleteSecret(string accountName, string databaseName, string secretName)

src/ResourceManager/DataLakeStore/ChangeLog.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,14 @@
1818
- Additional information about change #1
1919
-->
2020
## Current Release
21+
* Updated help for all cmdlets to include output as well as more descriptions of parameters and the inclusion of aliases.
22+
* Update New-AdlStore and Set-AdlStore to support commitment tier options for the service.
23+
* Added OutputType mismatch warnings to all cmdlets with incorrect OutputType attributes. These will be fixed in a future breaking change release.
24+
* Add Diagnostic logging support to Import-AdlStoreItem and Export-AdlStoreItem. This can be enabled through the following parameters:
25+
* -Debug, enables full diagnostic logging as well as debug logging to the PowerShell console. Most verbose options
26+
* -DiagnosticLogLevel, allows finer control of the output than debug. If used with debug, this is ignored and debug logging is used.
27+
* -DiagnosticLogPath, optionally specify the file to write diagnostic logs to. By default it is written to a file under %LOCALAPPDATA%\AdlDataTransfer
28+
* Added support to New-AdlStore to explicitly opt-out of account encryption. To do so, create the account with the -DisableEncryption flag.
2129

2230
## Version 3.2.0
2331
* Introduction of deprecation warning for nested properties for all ARM resources. Nested properties will be removed in a future release and all properties will be moved one level up.

0 commit comments

Comments
 (0)