Improved dynamic properties by adding them to a parameter set and providing more useful help messages.

Author: luanshixia

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Extensions/PsObjectExtensions.cs

@@ -133,5 +133,32 @@ private static JToken ToJToken(object value)
 
             return new JValue(value.ToString());
         }
+
+        /// <summary>
+        /// Gets nested property values from a <see cref="PSObject"/> easily using property path.
+        /// </summary>
+        /// <param name="propertyObject">The <see cref="PSObject"/> to get property value from.</param>
+        /// <param name="propertyPath">The nested property path, e.g. "metadata.description".</param>
+        /// <returns>The value of the specified property.</returns>
+        internal static object GetPSObjectProperty(this PSObject propertyObject, string propertyPath)
+        {
+            var propertyNames = propertyPath.Split('.');
+            var tmpObject = propertyObject;
+            foreach (var propertyName in propertyNames)
+            {
+                var propertyInfo = tmpObject.Properties[propertyName];
+                if (propertyInfo != null)
+                {
+                    if (propertyInfo.Value is PSObject)
+                    {
+                        tmpObject = propertyInfo.Value as PSObject;
+                        continue;
+                    }
+                    return propertyInfo.Value;
+                }
+                return null;
+            }
+            return tmpObject;
+        }
     }
 }

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Implementation/Policy/NewAzurePolicyAssignment.cs

@@ -156,29 +156,28 @@ object IDynamicParameters.GetDynamicParameters()
         {
             if (this.PolicyDefinition != null)
             {
-                var properties = this.PolicyDefinition.Properties["Properties"];
-                if (properties != null)
+                var parameters = this.PolicyDefinition.GetPSObjectProperty("Properties.parameters") as PSObject;
+                if (parameters != null)
                 {
-                    var parameters = (properties.Value as PSObject).Properties["parameters"];
-                    if (parameters != null)
+                    foreach (var param in parameters.Properties)
                     {
-                        foreach (var param in (parameters.Value as PSObject).Properties)
+                        var type = (param.Value as PSObject).Properties["type"];
+                        var typeString = type != null ? type.Value.ToString() : string.Empty;
+                        var description = (param.Value as PSObject).GetPSObjectProperty("metadata.description");
+                        var helpString = description != null ? description.ToString() : string.Format("The {0} policy parameter.", param.Name);
+                        var dp = new RuntimeDefinedParameter
                         {
-                            var type = (param.Value as PSObject).Properties["type"];
-                            var typeString = type != null ? type.Value.ToString() : string.Empty;
-                            var dp = new RuntimeDefinedParameter
-                            {
-                                Name = param.Name,
-                                ParameterType = typeString.Equals("array", StringComparison.OrdinalIgnoreCase) ? typeof(object[]) : typeof(string)
-                            };
-                            dp.Attributes.Add(new ParameterAttribute
-                            {
-                                Mandatory = false,
-                                ValueFromPipelineByPropertyName = true,
-                                HelpMessage = param.Name
-                            });
-                            this.dynamicParameters.Add(param.Name, dp);
-                        }
+                            Name = param.Name,
+                            ParameterType = typeString.Equals("array", StringComparison.OrdinalIgnoreCase) ? typeof(object[]) : typeof(string)
+                        };
+                        dp.Attributes.Add(new ParameterAttribute
+                        {
+                            ParameterSetName = ParameterlessPolicyParameterSetName,
+                            Mandatory = true,
+                            ValueFromPipelineByPropertyName = true,
+                            HelpMessage = helpString
+                        });
+                        this.dynamicParameters.Add(param.Name, dp);
                     }
                 }
             }