Simplify logic for GetDeploymentByName when passed as a PersistentVMRoleContext

Ed Munoz · Ed Munoz · commit 8b56714b9aed · 2015-04-20T16:36:18.000-07:00
diff --git a/src/ServiceManagement/Network/Commands.Network/NetworkClient.cs b/src/ServiceManagement/Network/Commands.Network/NetworkClient.cs
@@ -933,13 +933,12 @@ public string GetDeploymentBySlot(string serviceName, string slot)
                         slotType).Name;
         }
 
-        public string GetDeploymentName(IPersistentVM vm, string slot, string serviceName)
+        public string GetDeploymentName(PersistentVMRoleContext vm, string slot, string serviceName)
         {
             string deploymentName = null;
-            var vmRoleContext = vm as PersistentVMRoleContext;
-            if (vmRoleContext != null)
+            if (vm != null)
             {
-                deploymentName = vmRoleContext.DeploymentName;
+                deploymentName = vm.DeploymentName;
             }
 
             if (string.IsNullOrEmpty(slot) && string.IsNullOrEmpty(deploymentName))

Original file line number	Diff line number	Diff line change
`@@ -933,13 +933,12 @@ public string GetDeploymentBySlot(string serviceName, string slot)`
`933`	`933`	`slotType).Name;`
`934`	`934`	`}`
`935`	`935`
`936`		`- public string GetDeploymentName(IPersistentVM vm, string slot, string serviceName)`
	`936`	`+ public string GetDeploymentName(PersistentVMRoleContext vm, string slot, string serviceName)`
`937`	`937`	`{`
`938`	`938`	`string deploymentName = null;`
`939`		`- var vmRoleContext = vm as PersistentVMRoleContext;`
`940`		`- if (vmRoleContext != null)`
	`939`	`+ if (vm != null)`
`941`	`940`	`{`
`942`		`- deploymentName = vmRoleContext.DeploymentName;`
	`941`	`+ deploymentName = vm.DeploymentName;`
`943`	`942`	`}`
`944`	`943`
`945`	`944`	`if (string.IsNullOrEmpty(slot) && string.IsNullOrEmpty(deploymentName))`