Rerecord lb tests

Author: deepakswifty

src/ResourceManager/Network/Commands.Network.Test/Commands.Network.Test.csproj

@@ -165,6 +165,9 @@
     <None Include="ScenarioTests\PublicIpAddressTests.ps1">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
+    <None Include="SessionRecords\Commands.Network.Test.ScenarioTests.LoadBalancerTests\TestCreateEmptyLoadBalancer.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <None Include="SessionRecords\Commands.Network.Test.ScenarioTests.LoadBalancerTests\TestLoadBalancerCRUDInternalDynamic.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
@@ -204,6 +207,9 @@
     <None Include="SessionRecords\Commands.Network.Test.ScenarioTests.PublicIpAddressTests\TestPublicIpAddressCRUDNoDomainNameLabel.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
+    <None Include="SessionRecords\Commands.Network.Test.ScenarioTests.PublicIpAddressTests\TestPublicIpAddressCRUDReverseFqdn.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <None Include="SessionRecords\Commands.Network.Test.ScenarioTests.PublicIpAddressTests\TestPublicIpAddressCRUDStaticAllocation.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/LoadBalancerTests.cs

@@ -81,5 +81,12 @@ public void TestLoadBalancerSet()
         {
             NetworkResourcesController.NewInstance.RunPsTest("Test-LoadBalancerSet");
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestCreateEmptyLoadBalancer()
+        {
+            NetworkResourcesController.NewInstance.RunPsTest("Test-CreateEmptyLoadBalancer");
+        }
     }
 }

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/LoadBalancerTests.ps1

@@ -46,5 +46,12 @@ public void TestPublicIpAddressCRUDEditDomainNameLavel()
         {
             NetworkResourcesController.NewInstance.RunPsTest("Test-PublicIpAddressCRUD-EditDomainNameLavel");
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestPublicIpAddressCRUDReverseFqdn()
+        {
+            NetworkResourcesController.NewInstance.RunPsTest("Test-PublicIpAddressCRUD-ReverseFqdn");
+        }
     }
 }

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/PublicIpAddressTests.cs

@@ -219,4 +219,55 @@ function Test-PublicIpAddressCRUD-EditDomainNameLavel
         # Cleanup
         Clean-ResourceGroup $rgname
     }
+}
+
+<#
+.SYNOPSIS
+Tests edit the domain name label of a publicIpAddress.
+#>
+function Test-PublicIpAddressCRUD-ReverseFqdn
+{
+    # Setup
+    $rgname = Get-ResourceGroupName
+    $rname = Get-ResourceName
+    $domainNameLabel = Get-ResourceName
+    $rglocation = Get-ProviderLocation ResourceManagement
+    $resourceTypeParent = "Microsoft.Network/publicIpAddresses"
+    $location = Get-ProviderLocation $resourceTypeParent
+   
+    try 
+     {
+      # Create the resource group
+      $resourceGroup = New-AzureResourceGroup -Name $rgname -Location $rglocation -Tags @{Name = "testtag"; Value = "testval"} 
+      
+      # Create publicIpAddres
+      $actual = New-AzurePublicIpAddress -ResourceGroupName $rgname -name $rname -location $location -AllocationMethod Dynamic -DomainNameLabel $domainNameLabel
+      $publicip = Get-AzurePublicIpAddress -ResourceGroupName $rgname -name $rname
+      Assert-AreEqual $publicip.ResourceGroupName $actual.ResourceGroupName	
+      Assert-AreEqual $publicip.Name $actual.Name	
+      Assert-AreEqual $publicip.Location $actual.Location
+      Assert-AreEqual "Dynamic" $publicip.PublicIpAllocationMethod
+      Assert-AreEqual "Succeeded" $publicip.ProvisioningState
+      Assert-AreEqual $domainNameLabel $publicip.DnsSettings.DomainNameLabel
+      
+      $publicip.DnsSettings.ReverseFqdn = $publicip.DnsSettings.Fqdn
+
+      # Set publicIpAddress
+      $publicip | Set-AzurePublicIpAddress
+
+      $publicip = Get-AzurePublicIpAddress -ResourceGroupName $rgname -name $rname
+      Assert-AreEqual $publicip.DnsSettings.Fqdn $publicip.DnsSettings.ReverseFqdn
+      
+      # delete
+      $delete = Remove-AzurePublicIpAddress -ResourceGroupName $actual.ResourceGroupName -name $rname -PassThru -Force
+      Assert-AreEqual true $delete
+      
+      $list = Get-AzurePublicIpAddress -ResourceGroupName $actual.ResourceGroupName
+      Assert-AreEqual 0 @($list).Count
+    }
+    finally
+    {
+        # Cleanup
+        Clean-ResourceGroup $rgname
+    }
 }

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/PublicIpAddressTests.ps1

@@ -124,9 +124,12 @@ public static void NormalizeChildResourcesId(PSLoadBalancer loadBalancer)
             }
 
             // Normalize FrontendIpconfig
-            foreach (var frontendIpConfig in loadBalancer.FrontendIpConfigurations)
+            if (loadBalancer.FrontendIpConfigurations != null)
             {
-                frontendIpConfig.Id = string.Empty;
+                foreach (var frontendIpConfig in loadBalancer.FrontendIpConfigurations)
+                {
+                    frontendIpConfig.Id = string.Empty;
+                }
             }
 
             // Normalize Probe

src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.LoadBalancerTests/TestCreateEmptyLoadBalancer.json

@@ -75,7 +75,7 @@ public override void ExecuteCmdlet()
             }
 
             loadBalancingRule.FrontendIPConfiguration = null;
-            if (string.IsNullOrEmpty(this.FrontendIpConfigurationId))
+            if (!string.IsNullOrEmpty(this.FrontendIpConfigurationId))
             {
                 loadBalancingRule.FrontendIPConfiguration = new PSResourceId() { Id = this.FrontendIpConfigurationId };
             }

src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.LoadBalancerTests/TestLoadBalancerCRUDInternalDynamic.json

@@ -116,8 +116,11 @@ private PSLoadBalancer CreateLoadBalancer()
             loadBalancer.ResourceGroupName = this.ResourceGroupName;
             loadBalancer.Location = this.Location;
 
-            loadBalancer.FrontendIpConfigurations = new List<PSFrontendIPConfiguration>();
-            loadBalancer.FrontendIpConfigurations = this.FrontendIpConfiguration;
+            if (this.FrontendIpConfiguration != null)
+            {
+                loadBalancer.FrontendIpConfigurations = new List<PSFrontendIPConfiguration>();
+                loadBalancer.FrontendIpConfigurations = this.FrontendIpConfiguration;
+            }
 
             if (this.BackendAddressPool != null)
             {

src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.LoadBalancerTests/TestLoadBalancerCRUDInternalStatic.json

@@ -66,6 +66,12 @@ public class NewAzurePublicIpAddressCommand : PublicIpAddressBaseCmdlet
             HelpMessage = "The Domain Name label.")]
         public string DomainNameLabel { get; set; }
 
+        [Parameter(
+            Mandatory = false,
+            ValueFromPipelineByPropertyName = true,
+            HelpMessage = "The Reverse FQDN.")]
+        public string ReverseFqdn { get; set; }
+
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true,
@@ -118,6 +124,7 @@ private PSPublicIpAddress CreatePublicIpAddress()
             {
                 publicIp.DnsSettings = new PSPublicIpAddressDnsSettings();
                 publicIp.DnsSettings.DomainNameLabel = this.DomainNameLabel;
+                publicIp.DnsSettings.ReverseFqdn = this.ReverseFqdn;
             }
 
             var publicIpModel = Mapper.Map<MNM.PublicIpAddress>(publicIp);