FW: Fixing minor issues in the code, changing the return type of the Get-UsageMetrics Cmdlet.

Author: gucalder

src/ResourceManager/Insights/Commands.Insights.Test/UsageMetrics/GetUsageMetricsCommandTests.cs

@@ -49,7 +49,8 @@ public GetUsageMetricsCommandTests()
 
             response = Utilities.InitializeUsageMetricResponse();
 
-            insightsUsageMetricOperationsMock.Setup(f => f.ListAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<CancellationToken>()))
+            insightsUsageMetricOperationsMock
+                .Setup(f => f.ListAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<CancellationToken>()))
                 .Returns(Task.FromResult<UsageMetricListResponse>(response))
                 .Callback((string f, string s, string a, CancellationToken t) =>
                 {
@@ -58,7 +59,9 @@ public GetUsageMetricsCommandTests()
                     apiVersion = a;
                 });
 
-            insightsClientMock.SetupGet(f => f.UsageMetricOperations).Returns(this.insightsUsageMetricOperationsMock.Object);
+            insightsClientMock
+                .SetupGet(f => f.UsageMetricOperations)
+                .Returns(this.insightsUsageMetricOperationsMock.Object);
         }
 
         private void CleanParamVariables()

src/ResourceManager/Insights/Commands.Insights/UsageMetrics/GetUsageMetricsCommand.cs

@@ -25,14 +25,18 @@ namespace Microsoft.Azure.Commands.Insights.UsageMetrics
     /// <summary>
     /// Get the list of usage metrics for a resource.
     /// </summary>
-    [Cmdlet(VerbsCommon.Get, "UsageMetrics"), OutputType(typeof(UsageMetric[]))]
+    [Cmdlet(VerbsCommon.Get, "UsageMetrics"), OutputType(typeof(PSUsageMetric[]))]
     public class GetUsageMetricsCommand : InsightsClientCmdletBase
     {
         /// <summary>
         /// Default value of the timerange to search for usage metrics
         /// </summary>
         public static readonly TimeSpan DefaultTimeRange = TimeSpan.FromHours(1);
 
+        /// <summary>
+        /// Default API version string for the underlying RP.
+        /// The Insights backend gets the data from the RPs, and the RPs don not necessarily use the same API version.
+        /// </summary>
         public static readonly string DefaultApiVersion = "2014-04-01";
 
         /// <summary>
@@ -77,7 +81,9 @@ protected string ProcessParameters()
             var buffer = new StringBuilder();
             if (this.MetricNames != null)
             {
-                var metrics = this.MetricNames.Select(n => string.Concat("name.value eq '", n, "'")).Aggregate((a, b) => string.Concat(a, " or ", b));
+                var metrics = this.MetricNames
+                    .Select(n => string.Concat("name.value eq '", n, "'"))
+                    .Aggregate((a, b) => string.Concat(a, " or ", b));
 
                 buffer.Append("(");
                 buffer.Append(metrics);
@@ -120,8 +126,12 @@ protected override void ExecuteCmdletInternal()
 
             // Call the proper API methods to return a list of raw records.
             // If fullDetails is present full details of the records displayed, otherwise only a summary of the values is displayed
-            UsageMetricListResponse response = this.InsightsClient.UsageMetricOperations.ListAsync(resourceUri: this.ResourceId, filterString: queryFilter, apiVersion: apiVersion, cancellationToken: CancellationToken.None).Result;
-            var records = response.UsageMetricCollection.Value.Select(e => new PSUsageMetric(e)).ToArray();
+            UsageMetricListResponse response = this.InsightsClient.UsageMetricOperations
+                .ListAsync(resourceUri: this.ResourceId, filterString: queryFilter, apiVersion: apiVersion, cancellationToken: CancellationToken.None)
+                .Result;
+            var records = response.UsageMetricCollection.Value
+                .Select(e => new PSUsageMetric(e))
+                .ToArray();
 
             WriteObject(sendToPipeline: records);
         }