addbridge! -> add_bridge

Author: blegat

docs/src/apireference.md

@@ -326,7 +326,7 @@ Bridges.AbstractBridge
 Bridges.AbstractBridgeOptimizer
 Bridges.SingleBridgeOptimizer
 Bridges.LazyBridgeOptimizer
-Bridges.addbridge!
+Bridges.add_bridge
 ```
 
 Below is the list of bridges implemented in this package.

src/Bridges/Bridges.jl

@@ -32,14 +32,14 @@ Returns a `LazyBridgeOptimizer` bridging `model` for every bridge defined in thi
 """
 function fullbridgeoptimizer(model::MOI.ModelLike, ::Type{T}) where T
     bridgedmodel = MOIB.LazyBridgeOptimizer(model, AllBridgedConstraints{T}())
-    addbridge!(bridgedmodel, MOIB.SplitIntervalBridge{T})
-    addbridge!(bridgedmodel, MOIB.GeoMeanBridge{T})
-    addbridge!(bridgedmodel, MOIB.SquarePSDBridge{T})
-    addbridge!(bridgedmodel, MOIB.LogDetBridge{T})
-    addbridge!(bridgedmodel, MOIB.RootDetBridge{T})
-    addbridge!(bridgedmodel, MOIB.RSOCBridge{T})
-    addbridge!(bridgedmodel, MOIB.RSOCtoPSDBridge{T})
-    addbridge!(bridgedmodel, MOIB.SOCtoPSDBridge{T})
+    add_bridge(bridgedmodel, MOIB.SplitIntervalBridge{T})
+    add_bridge(bridgedmodel, MOIB.GeoMeanBridge{T})
+    add_bridge(bridgedmodel, MOIB.SquarePSDBridge{T})
+    add_bridge(bridgedmodel, MOIB.LogDetBridge{T})
+    add_bridge(bridgedmodel, MOIB.RootDetBridge{T})
+    add_bridge(bridgedmodel, MOIB.RSOCBridge{T})
+    add_bridge(bridgedmodel, MOIB.RSOCtoPSDBridge{T})
+    add_bridge(bridgedmodel, MOIB.SOCtoPSDBridge{T})
     bridgedmodel
 end
 

src/Bridges/lazybridgeoptimizer.jl

@@ -2,7 +2,7 @@
 """
     LazyBridgeOptimizer{OT<:MOI.ModelLike, MT<:MOI.ModelLike} <: AbstractBridgeOptimizer
 
-The `LazyBridgeOptimizer` combines several bridges, which are added using the [`addbridge!`](@ref) function.
+The `LazyBridgeOptimizer` combines several bridges, which are added using the [`add_bridge`](@ref) function.
 Whenever a constraint is added, it only attempts to bridge it if it is not supported by the internal model (hence its name `Lazy`).
 When bridging a constraint, it selects the minimal number of bridges needed.
 For instance, a constraint `F`-in-`S` can be bridged into a constraint `F1`-in-`S1` (supported by the internal model) using bridge 1 or
@@ -84,11 +84,11 @@ function update_constraint!(b::LazyBridgeOptimizer, F::Type{<:MOI.AbstractFuncti
 end
 
 """
-    addbridge!(b::LazyBridgeOptimizer, BT::Type{<:AbstractBridge})
+    add_bridge(b::LazyBridgeOptimizer, BT::Type{<:AbstractBridge})
 
 Enable the use of the bridges of type `BT` by `b`.
 """
-function addbridge!(b::LazyBridgeOptimizer, BT::Type{<:AbstractBridge})
+function add_bridge(b::LazyBridgeOptimizer, BT::Type{<:AbstractBridge})
     push!(b.bridgetypes, BT)
     # Some constraints (F, S) in keys(b.best) may now be bridged
     # with a less briges than `b.dist[(F, S)] using `BT`

test/bridge.jl

@@ -114,10 +114,10 @@ MOIU.@model NoRSOCModel () (EqualTo, GreaterThan, LessThan, Interval) (Zeros, No
 @testset "LazyBridgeOptimizer" begin
     mock = MOIU.MockOptimizer(NoRSOCModel{Float64}())
     bridgedmock = MOIB.LazyBridgeOptimizer(mock, Model{Float64}())
-    MOIB.addbridge!(bridgedmock, MOIB.SplitIntervalBridge{Float64})
-    MOIB.addbridge!(bridgedmock, MOIB.RSOCtoPSDBridge{Float64})
-    MOIB.addbridge!(bridgedmock, MOIB.SOCtoPSDBridge{Float64})
-    MOIB.addbridge!(bridgedmock, MOIB.RSOCBridge{Float64})
+    MOIB.add_bridge(bridgedmock, MOIB.SplitIntervalBridge{Float64})
+    MOIB.add_bridge(bridgedmock, MOIB.RSOCtoPSDBridge{Float64})
+    MOIB.add_bridge(bridgedmock, MOIB.SOCtoPSDBridge{Float64})
+    MOIB.add_bridge(bridgedmock, MOIB.RSOCBridge{Float64})
 
     @testset "Name test" begin
         MOIT.nametest(bridgedmock)