Fixes to get tests passing

Author: odow

src/Bridges/bridgeoptimizer.jl

@@ -225,6 +225,25 @@ function MOI.modifyconstraint!(b::AbstractBridgeOptimizer, ci::CI, change)
     end
 end
 
+function MOI.canset(b::AbstractBridgeOptimizer, ::MOI.ConstraintSet, ::Type{C}) where C <: CI
+    if isbridged(b, C)
+       MOI.canset(b.bridged, MOI.ConstraintSet(), C)
+        # TODO(@blegat) is this necessary? How do I do it without types
+        # && MOI.canset(b, MOIB.bridge(b, ci), change)
+    else
+        MOI.canset(b.model, MOI.ConstraintSet(), C)
+    end
+end
+function MOI.set!(b::AbstractBridgeOptimizer, ::MOI.ConstraintSet, constraint_index::CI, set)
+    # Note: we also under-type this function to avoid ambiguity
+    if isbridged(b, typeof(constraint_index))
+        MOI.set!(b, MOI.ConstraintSet(), bridge(b, constraint_index), set)
+        MOI.set!(b.bridged, MOI.ConstraintSet(), constraint_index, set)
+    else
+        MOI.set!(b.model, MOI.ConstraintSet(), constraint_index, set)
+    end
+end
+
 # Objective
 MOI.canmodifyobjective(b::AbstractBridgeOptimizer, ::Type{M}) where M<:MOI.AbstractFunctionModification = MOI.canmodifyobjective(b.model, M)
 MOI.modifyobjective!(b::AbstractBridgeOptimizer, change::MOI.AbstractFunctionModification) = MOI.modifyobjective!(b.model, change)

src/Utilities/model.jl

@@ -252,10 +252,15 @@ MOI.canmodifyconstraint(::AbstractModel, ::CI, ::Type{<:MOI.AbstractFunctionModi
 function MOI.modifyconstraint!(model::AbstractModel, ci::CI, change::MOI.AbstractFunctionModification)
     _modifyconstraint!(model, ci, getconstrloc(model, ci), change)
 end
-MOI.canset(::AbstractModel, ::MOI.ConstraintFunction, ::Type{<:CI}) = true
-function MOI.set!(model::AbstractModel, ::MOI.ConstraintFunction, ci::CI, change::MOI.AbstractFunction)
+
+MOI.canmodifyconstraint(::AbstractModel, ::CI, ::Type{<:MOI.AbstractFunction}) = true
+function MOI.modifyconstraint!(model::AbstractModel, ci::CI, change::MOI.AbstractFunction)
     _modifyconstraint!(model, ci, getconstrloc(model, ci), change)
 end
+# MOI.canset(::AbstractModel, ::MOI.ConstraintFunction, ::Type{<:CI}) = true
+# function MOI.set!(model::AbstractModel, ::MOI.ConstraintFunction, ci::CI, change::MOI.AbstractFunction)
+#     _modifyconstraint!(model, ci, getconstrloc(model, ci), change)
+# end
 MOI.canset(::AbstractModel, ::MOI.ConstraintSet, ::Type{<:CI}) = true
 function MOI.set!(model::AbstractModel, ::MOI.ConstraintSet, ci::CI, change::MOI.AbstractSet)
     _modifyconstraint!(model, ci, getconstrloc(model, ci), change)

test/model.jl

@@ -62,7 +62,8 @@ end
     f3 = MOIU.modifyfunction(f3, MOI.ScalarCoefficientChange(y, 2))
 
     @test !(MOI.get(model, MOI.ConstraintFunction(), c1) ≈ f3)
-    MOI.set!(model, MOI.ConstraintFunction(), c1, f3)
+    MOI.modifyconstraint!(model, c1, f3)
+    # MOI.set!(model, MOI.ConstraintFunction(), c1, f3)
     @test MOI.get(model, MOI.ConstraintFunction(), c1) ≈ f3
 
     f4 = MOI.VectorAffineFunction(MOI.VectorAffineTerm.([1, 1, 2], MOI.ScalarAffineTerm.([2, 4, 3], [x, y, y])), [5, 7])