Tidy functions.jl and improve docstrings #2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
reviewed
Mar 1, 2023
| ]; | ||
|
|
||
| julia> f = MOI.VectorQuadraticFunction(quad_terms, affine_terms, constants) | ||
| MathOptInterface.VectorQuadraticFunction{Float64}(MathOptInterface.VectorQuadraticTerm{Float64}[MathOptInterface.VectorQuadraticTerm{Float64}(1, MathOptInterface.ScalarQuadraticTerm{Float64}(2.0, MathOptInterface.VariableIndex(1), MathOptInterface.VariableIndex(1))), MathOptInterface.VectorQuadraticTerm{Float64}(2, MathOptInterface.ScalarQuadraticTerm{Float64}(3.0, MathOptInterface.VariableIndex(1), MathOptInterface.VariableIndex(2)))], MathOptInterface.VectorAffineTerm{Float64}[MathOptInterface.VectorAffineTerm{Float64}(1, MathOptInterface.ScalarAffineTerm{Float64}(2.0, MathOptInterface.VariableIndex(1))), MathOptInterface.VectorAffineTerm{Float64}(2, MathOptInterface.ScalarAffineTerm{Float64}(3.0, MathOptInterface.VariableIndex(1)))], [4.0, 5.0]) |
There was a problem hiding this comment.
We should really improve the printing of functions, debugging it awful atm
There was a problem hiding this comment.
Yes. But that can be a separate PR.
I even wonder about something like:
ScalarAffineFunction:
constant: 1.0
terms:
VariableIndex(1) => 2.0
VariableIndex(2) => 2.0
VariableIndex(3) => 2.0
VariableIndex(4) => 2.0Rather than trying to pretty-print it all.
There was a problem hiding this comment.
I would prefer pretty printing for the oneline version as it is sometimes coefficients of a multivariate polynomials that is trying to print itself in oneline.
There was a problem hiding this comment.
For the long version, your suggestion seems nice
There was a problem hiding this comment.
Open an issue? What is the "long version"?
blegat
reviewed
Mar 1, 2023
Co-authored-by: Benoît Legat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #2099
Preview: https://jump.dev/MathOptInterface.jl/previews/PR2108/reference/standard_form/