Skip to content

[Test] warn on ambiguous string in exclude #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2023
Merged

[Test] warn on ambiguous string in exclude #2136

merged 2 commits into from
Apr 5, 2023

Conversation

odow
Copy link
Member

@odow odow commented Apr 5, 2023

Closes #2127

@blegat is this what you had in mind?

blegat
blegat reviewed Apr 5, 2023
View reviewed changes
blegat
blegat approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@odow @blegat
Update src/Test/Test.jl
28e3e4d 
Co-authored-by: Benoît Legat <[email protected]>
@odow odow merged commit 63b7f74 into master Apr 5, 2023
@odow odow deleted the od/warn-ambiguous-test branch April 5, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test names clash
2 participants
@odow @blegat