Skip to content

[docs] filter varying width Time column in doctest #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025

Conversation

mortenpi
Copy link
Contributor

@mortenpi mortenpi commented May 8, 2025

I didn't explicitly verify this, but I think this should hopefully avoid the doctest failure we sometimes see (JuliaDocs/Documenter.jl#2704).

@mortenpi mortenpi marked this pull request as ready for review May 8, 2025 02:55
Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I got confused. The Time column shifted over because of the extra digit in the time.

@mortenpi
Copy link
Contributor Author

mortenpi commented May 8, 2025

Hmm. I am not sure we need to escape in the Markdown files actually.

@odow
Copy link
Member

odow commented May 8, 2025

Oh just the docstrings?

@mortenpi
Copy link
Contributor Author

mortenpi commented May 8, 2025

I think so.. I think it's just the string literals in Julia code where we have the notion of escape sequences. This worked correctly as far as I can tell:

image

@odow odow merged commit ecdf735 into jump-dev:master May 8, 2025
30 checks passed
@odow odow mentioned this pull request May 18, 2025
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants