Add test_delete_bridge function #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
force-pushed
the
bl/testdelbridge
branch
from
3c56e46 to
7c2fb77
Compare
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 30 30
Lines 4525 4525
=======================================
Hits 4366 4366
Misses 159 159Continue to review full report at Codecov.
|
mlubin
reviewed
Apr 22, 2018
| @test isempty(m.bridges) | ||
| test_noc(m, F, S, 0) | ||
| # As the bridge has been removed, if the constraints it has created where not removed, it wouldn't be there to decrease this counter anymore | ||
| @test MOI.get(m, MOI.NumberOfVariables()) == nvars |
There was a problem hiding this comment.
Do bridges change the value of MOI.NumberOfVariables() that's visible to users?
There was a problem hiding this comment.
If it adds variables as part of the reformulation, it needs to hide it from the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.