Skip to content

Updates to LazyBridgeOptimizers #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2018
Merged

Updates to LazyBridgeOptimizers #383

merged 4 commits into from
Jun 10, 2018

Conversation

blegat
Copy link
Member

@blegat blegat commented Jun 9, 2018

These updates addresses @odow 's comments made on #362.
These commits were written 22 days ago and were meant to be pushed to that PR but it seems I forgot to push.

@blegat blegat force-pushed the bl/bridgeupdate branch from 63f0bc2 to ce8dc33 Compare June 9, 2018 20:06
@codecov-io
Copy link

codecov-io commented Jun 9, 2018

Codecov Report

Merging #383 into master will decrease coverage by 0.01%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
- Coverage   96.35%   96.34%   -0.02%     
==========================================
  Files          40       40              
  Lines        4886     4898      +12     
==========================================
+ Hits         4708     4719      +11     
- Misses        178      179       +1
Impacted Files Coverage Δ
src/Bridges/intervalbridge.jl 100% <ø> (ø) ⬆️
src/Bridges/soctopsdbridge.jl 100% <100%> (ø) ⬆️
src/Bridges/bridge.jl 100% <100%> (ø) ⬆️
src/Bridges/rsocbridge.jl 100% <100%> (ø) ⬆️
src/Bridges/detbridge.jl 100% <100%> (ø) ⬆️
src/Bridges/geomeanbridge.jl 100% <100%> (ø) ⬆️
src/Bridges/lazybridgeoptimizer.jl 97.14% <95.23%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4805984...ce8dc33. Read the comment docs.

Copy link
Member

@mlubin mlubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odow, please take a look

@blegat blegat merged commit dcc5ebb into master Jun 10, 2018
@blegat blegat deleted the bl/bridgeupdate branch August 28, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants