Skip to content

Add tests for ObjectiveBound #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2018
Merged

Add tests for ObjectiveBound #446

merged 2 commits into from
Aug 4, 2018

Conversation

odow
Copy link
Member

@odow odow commented Aug 3, 2018

Ref #442

@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #446 into master will increase coverage by 0.4%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #446     +/-   ##
=========================================
+ Coverage   94.58%   94.99%   +0.4%     
=========================================
  Files          41       42      +1     
  Lines        4895     4933     +38     
=========================================
+ Hits         4630     4686     +56     
+ Misses        265      247     -18
Impacted Files Coverage Δ
src/Test/UnitTests/unit_tests.jl 100% <ø> (ø) ⬆️
src/Test/UnitTests/solve.jl 100% <100%> (ø)
src/Utilities/mockoptimizer.jl 95.2% <80%> (-0.47%) ⬇️
src/Bridges/detbridge.jl 98.79% <0%> (-1.21%) ⬇️
src/Test/intlinear.jl 97.46% <0%> (+0.42%) ⬆️
src/Utilities/functions.jl 98.19% <0%> (+2.25%) ⬆️
src/Utilities/parser.jl 97.65% <0%> (+10.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee34ab...e921ab3. Read the comment docs.

@testset "Min IP with constant" begin
MOI.empty!(model)
@test MOI.isempty(model)
MOIU.loadfromstring!(model,"""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nittiest of nits: space before """

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated below.

""")
x = MOI.get(model, MOI.VariableIndex, "x")
test_model_solution(model, config;
objective_value = 3.0,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncessary white space?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated below.

@mlubin mlubin merged commit dcc9264 into master Aug 4, 2018
@mlubin mlubin deleted the od/objbound branch August 4, 2018 13:09
@blegat blegat mentioned this pull request Aug 18, 2018
@odow odow mentioned this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants