Use MOI.delete instead of Base.delete! #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 46 46
Lines 4681 4681
=======================================
Hits 4465 4465
Misses 216 216
Continue to review full report at Codecov.
|
mlubin
approved these changes
Aug 25, 2018
blegat
force-pushed
the
bl/delete
branch
2 times, most recently
from
3db2265 to
abbf618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that
MOIU.IndexMapstill overloadsBase.delete!as it is a dictionary-like object and not aModelLike.Since
MOI.delete!used to be equivalentBase.delete!this renaming wasn't just a matter of search and replace :-P It might be a good thing for code readability that these are now different.Closes #475