Broadcast attributes #513
Merged
Broadcast attributes #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
=========================================
- Coverage 95.62% 95.6% -0.03%
=========================================
Files 46 46
Lines 4704 4705 +1
=========================================
Hits 4498 4498
- Misses 206 207 +1
Continue to review full report at Codecov.
|
mlubin
reviewed
Aug 28, 2018
| @@ -183,7 +189,7 @@ function get end | |||
| # We want to avoid being too specific in the type arguments to avoid method ambiguity. | |||
| # For model, get(::ModelLike, ::AbstractVariableAttribute, ::Vector{VariableIndex}) would not allow | |||
| # to define get(::SomeModel, ::AnyAttribute, ::Vector) | |||
| get(model::ModelLike, attr::AnyAttribute, idxs::Vector) = get.(model, Ref(attr), idxs) | |||
| get(model::ModelLike, attr::AnyAttribute, idxs::Vector) = get.(model, attr, idxs) | |||
There was a problem hiding this comment.
Do we still need this fallback or should users just broadcast themselves?
There was a problem hiding this comment.
Some solvers may do something faster, e.g. if they have a fixed cost that can be shared when getting by group
mlubin
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to put
Ref's in ECOS because of broadcasting attributes and now that I am updating SDOI, I need them again... Probably better to just define the attributes here as scalar :)