Skip to content

Commit ba3799f

Browse files
ulleniusstefanbirkner
authored andcommitted
Reordering the modifiers to comply with the JLS:
* Java Language Specification
1 parent 318e5a7 commit ba3799f

25 files changed

+124
-124
lines changed

src/main/java/junit/extensions/ActiveTestSuite.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ synchronized void waitUntilFinished() {
6363
}
6464
}
6565

66-
synchronized public void runFinished() {
66+
public synchronized void runFinished() {
6767
fActiveTestDeathCount++;
6868
notifyAll();
6969
}

src/main/java/junit/framework/Assert.java

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ protected Assert() {
1717
* Asserts that a condition is true. If it isn't it throws
1818
* an AssertionFailedError with the given message.
1919
*/
20-
static public void assertTrue(String message, boolean condition) {
20+
public static void assertTrue(String message, boolean condition) {
2121
if (!condition) {
2222
fail(message);
2323
}
@@ -27,30 +27,30 @@ static public void assertTrue(String message, boolean condition) {
2727
* Asserts that a condition is true. If it isn't it throws
2828
* an AssertionFailedError.
2929
*/
30-
static public void assertTrue(boolean condition) {
30+
public static void assertTrue(boolean condition) {
3131
assertTrue(null, condition);
3232
}
3333

3434
/**
3535
* Asserts that a condition is false. If it isn't it throws
3636
* an AssertionFailedError with the given message.
3737
*/
38-
static public void assertFalse(String message, boolean condition) {
38+
public static void assertFalse(String message, boolean condition) {
3939
assertTrue(message, !condition);
4040
}
4141

4242
/**
4343
* Asserts that a condition is false. If it isn't it throws
4444
* an AssertionFailedError.
4545
*/
46-
static public void assertFalse(boolean condition) {
46+
public static void assertFalse(boolean condition) {
4747
assertFalse(null, condition);
4848
}
4949

5050
/**
5151
* Fails a test with the given message.
5252
*/
53-
static public void fail(String message) {
53+
public static void fail(String message) {
5454
if (message == null) {
5555
throw new AssertionFailedError();
5656
}
@@ -60,15 +60,15 @@ static public void fail(String message) {
6060
/**
6161
* Fails a test with no message.
6262
*/
63-
static public void fail() {
63+
public static void fail() {
6464
fail(null);
6565
}
6666

6767
/**
6868
* Asserts that two objects are equal. If they are not
6969
* an AssertionFailedError is thrown with the given message.
7070
*/
71-
static public void assertEquals(String message, Object expected, Object actual) {
71+
public static void assertEquals(String message, Object expected, Object actual) {
7272
if (expected == null && actual == null) {
7373
return;
7474
}
@@ -82,14 +82,14 @@ static public void assertEquals(String message, Object expected, Object actual)
8282
* Asserts that two objects are equal. If they are not
8383
* an AssertionFailedError is thrown.
8484
*/
85-
static public void assertEquals(Object expected, Object actual) {
85+
public static void assertEquals(Object expected, Object actual) {
8686
assertEquals(null, expected, actual);
8787
}
8888

8989
/**
9090
* Asserts that two Strings are equal.
9191
*/
92-
static public void assertEquals(String message, String expected, String actual) {
92+
public static void assertEquals(String message, String expected, String actual) {
9393
if (expected == null && actual == null) {
9494
return;
9595
}
@@ -103,7 +103,7 @@ static public void assertEquals(String message, String expected, String actual)
103103
/**
104104
* Asserts that two Strings are equal.
105105
*/
106-
static public void assertEquals(String expected, String actual) {
106+
public static void assertEquals(String expected, String actual) {
107107
assertEquals(null, expected, actual);
108108
}
109109

@@ -112,7 +112,7 @@ static public void assertEquals(String expected, String actual) {
112112
* an AssertionFailedError is thrown with the given message. If the expected
113113
* value is infinity then the delta value is ignored.
114114
*/
115-
static public void assertEquals(String message, double expected, double actual, double delta) {
115+
public static void assertEquals(String message, double expected, double actual, double delta) {
116116
if (Double.compare(expected, actual) == 0) {
117117
return;
118118
}
@@ -125,7 +125,7 @@ static public void assertEquals(String message, double expected, double actual,
125125
* Asserts that two doubles are equal concerning a delta. If the expected
126126
* value is infinity then the delta value is ignored.
127127
*/
128-
static public void assertEquals(double expected, double actual, double delta) {
128+
public static void assertEquals(double expected, double actual, double delta) {
129129
assertEquals(null, expected, actual, delta);
130130
}
131131

@@ -134,7 +134,7 @@ static public void assertEquals(double expected, double actual, double delta) {
134134
* are not an AssertionFailedError is thrown with the given message. If the
135135
* expected value is infinity then the delta value is ignored.
136136
*/
137-
static public void assertEquals(String message, float expected, float actual, float delta) {
137+
public static void assertEquals(String message, float expected, float actual, float delta) {
138138
if (Float.compare(expected, actual) == 0) {
139139
return;
140140
}
@@ -147,112 +147,112 @@ static public void assertEquals(String message, float expected, float actual, fl
147147
* Asserts that two floats are equal concerning a delta. If the expected
148148
* value is infinity then the delta value is ignored.
149149
*/
150-
static public void assertEquals(float expected, float actual, float delta) {
150+
public static void assertEquals(float expected, float actual, float delta) {
151151
assertEquals(null, expected, actual, delta);
152152
}
153153

154154
/**
155155
* Asserts that two longs are equal. If they are not
156156
* an AssertionFailedError is thrown with the given message.
157157
*/
158-
static public void assertEquals(String message, long expected, long actual) {
158+
public static void assertEquals(String message, long expected, long actual) {
159159
assertEquals(message, Long.valueOf(expected), Long.valueOf(actual));
160160
}
161161

162162
/**
163163
* Asserts that two longs are equal.
164164
*/
165-
static public void assertEquals(long expected, long actual) {
165+
public static void assertEquals(long expected, long actual) {
166166
assertEquals(null, expected, actual);
167167
}
168168

169169
/**
170170
* Asserts that two booleans are equal. If they are not
171171
* an AssertionFailedError is thrown with the given message.
172172
*/
173-
static public void assertEquals(String message, boolean expected, boolean actual) {
173+
public static void assertEquals(String message, boolean expected, boolean actual) {
174174
assertEquals(message, Boolean.valueOf(expected), Boolean.valueOf(actual));
175175
}
176176

177177
/**
178178
* Asserts that two booleans are equal.
179179
*/
180-
static public void assertEquals(boolean expected, boolean actual) {
180+
public static void assertEquals(boolean expected, boolean actual) {
181181
assertEquals(null, expected, actual);
182182
}
183183

184184
/**
185185
* Asserts that two bytes are equal. If they are not
186186
* an AssertionFailedError is thrown with the given message.
187187
*/
188-
static public void assertEquals(String message, byte expected, byte actual) {
188+
public static void assertEquals(String message, byte expected, byte actual) {
189189
assertEquals(message, Byte.valueOf(expected), Byte.valueOf(actual));
190190
}
191191

192192
/**
193193
* Asserts that two bytes are equal.
194194
*/
195-
static public void assertEquals(byte expected, byte actual) {
195+
public static void assertEquals(byte expected, byte actual) {
196196
assertEquals(null, expected, actual);
197197
}
198198

199199
/**
200200
* Asserts that two chars are equal. If they are not
201201
* an AssertionFailedError is thrown with the given message.
202202
*/
203-
static public void assertEquals(String message, char expected, char actual) {
203+
public static void assertEquals(String message, char expected, char actual) {
204204
assertEquals(message, Character.valueOf(expected), Character.valueOf(actual));
205205
}
206206

207207
/**
208208
* Asserts that two chars are equal.
209209
*/
210-
static public void assertEquals(char expected, char actual) {
210+
public static void assertEquals(char expected, char actual) {
211211
assertEquals(null, expected, actual);
212212
}
213213

214214
/**
215215
* Asserts that two shorts are equal. If they are not
216216
* an AssertionFailedError is thrown with the given message.
217217
*/
218-
static public void assertEquals(String message, short expected, short actual) {
218+
public static void assertEquals(String message, short expected, short actual) {
219219
assertEquals(message, Short.valueOf(expected), Short.valueOf(actual));
220220
}
221221

222222
/**
223223
* Asserts that two shorts are equal.
224224
*/
225-
static public void assertEquals(short expected, short actual) {
225+
public static void assertEquals(short expected, short actual) {
226226
assertEquals(null, expected, actual);
227227
}
228228

229229
/**
230230
* Asserts that two ints are equal. If they are not
231231
* an AssertionFailedError is thrown with the given message.
232232
*/
233-
static public void assertEquals(String message, int expected, int actual) {
233+
public static void assertEquals(String message, int expected, int actual) {
234234
assertEquals(message, Integer.valueOf(expected), Integer.valueOf(actual));
235235
}
236236

237237
/**
238238
* Asserts that two ints are equal.
239239
*/
240-
static public void assertEquals(int expected, int actual) {
240+
public static void assertEquals(int expected, int actual) {
241241
assertEquals(null, expected, actual);
242242
}
243243

244244
/**
245245
* Asserts that an object isn't null.
246246
*/
247-
static public void assertNotNull(Object object) {
247+
public static void assertNotNull(Object object) {
248248
assertNotNull(null, object);
249249
}
250250

251251
/**
252252
* Asserts that an object isn't null. If it is
253253
* an AssertionFailedError is thrown with the given message.
254254
*/
255-
static public void assertNotNull(String message, Object object) {
255+
public static void assertNotNull(String message, Object object) {
256256
assertTrue(message, object != null);
257257
}
258258

@@ -263,7 +263,7 @@ static public void assertNotNull(String message, Object object) {
263263
*
264264
* @param object Object to check or <code>null</code>
265265
*/
266-
static public void assertNull(Object object) {
266+
public static void assertNull(Object object) {
267267
if (object != null) {
268268
assertNull("Expected: <null> but was: " + object.toString(), object);
269269
}
@@ -273,15 +273,15 @@ static public void assertNull(Object object) {
273273
* Asserts that an object is null. If it is not
274274
* an AssertionFailedError is thrown with the given message.
275275
*/
276-
static public void assertNull(String message, Object object) {
276+
public static void assertNull(String message, Object object) {
277277
assertTrue(message, object == null);
278278
}
279279

280280
/**
281281
* Asserts that two objects refer to the same object. If they are not
282282
* an AssertionFailedError is thrown with the given message.
283283
*/
284-
static public void assertSame(String message, Object expected, Object actual) {
284+
public static void assertSame(String message, Object expected, Object actual) {
285285
if (expected == actual) {
286286
return;
287287
}
@@ -292,7 +292,7 @@ static public void assertSame(String message, Object expected, Object actual) {
292292
* Asserts that two objects refer to the same object. If they are not
293293
* the same an AssertionFailedError is thrown.
294294
*/
295-
static public void assertSame(Object expected, Object actual) {
295+
public static void assertSame(Object expected, Object actual) {
296296
assertSame(null, expected, actual);
297297
}
298298

@@ -301,7 +301,7 @@ static public void assertSame(Object expected, Object actual) {
301301
* refer to the same object an AssertionFailedError is thrown with the
302302
* given message.
303303
*/
304-
static public void assertNotSame(String message, Object expected, Object actual) {
304+
public static void assertNotSame(String message, Object expected, Object actual) {
305305
if (expected == actual) {
306306
failSame(message);
307307
}
@@ -311,21 +311,21 @@ static public void assertNotSame(String message, Object expected, Object actual)
311311
* Asserts that two objects do not refer to the same object. If they do
312312
* refer to the same object an AssertionFailedError is thrown.
313313
*/
314-
static public void assertNotSame(Object expected, Object actual) {
314+
public static void assertNotSame(Object expected, Object actual) {
315315
assertNotSame(null, expected, actual);
316316
}
317317

318-
static public void failSame(String message) {
318+
public static void failSame(String message) {
319319
String formatted = (message != null) ? message + " " : "";
320320
fail(formatted + "expected not same");
321321
}
322322

323-
static public void failNotSame(String message, Object expected, Object actual) {
323+
public static void failNotSame(String message, Object expected, Object actual) {
324324
String formatted = (message != null) ? message + " " : "";
325325
fail(formatted + "expected same:<" + expected + "> was not:<" + actual + ">");
326326
}
327327

328-
static public void failNotEquals(String message, Object expected, Object actual) {
328+
public static void failNotEquals(String message, Object expected, Object actual) {
329329
fail(format(message, expected, actual));
330330
}
331331

src/main/java/org/junit/runner/notification/RunNotifier.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ void run() {
7878
fireTestFailures(safeListeners, failures);
7979
}
8080

81-
abstract protected void notifyListener(RunListener each) throws Exception;
81+
protected abstract void notifyListener(RunListener each) throws Exception;
8282
}
8383

8484
/**

src/main/java/org/junit/validator/AnnotationsValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public List<Exception> validateTestClass(TestClass testClass) {
4040
return validationErrors;
4141
}
4242

43-
private static abstract class AnnotatableValidator<T extends Annotatable> {
43+
private abstract static class AnnotatableValidator<T extends Annotatable> {
4444
private static final AnnotationValidatorFactory ANNOTATION_VALIDATOR_FACTORY = new AnnotationValidatorFactory();
4545

4646
abstract Iterable<T> getAnnotatablesForTestClass(TestClass testClass);

src/test/java/junit/tests/runner/ResultTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ private void assertResultReserializable(Result result, SerializationFormat resou
9696
fromStream, resourceSerializationFormat);
9797
}
9898

99-
static public class AssumptionFailedTest {
99+
public static class AssumptionFailedTest {
100100
@Test
101101
public void assumptionFailed() throws Exception {
102102
org.junit.Assume.assumeTrue(false);

src/test/java/org/junit/experimental/categories/CategoryTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ public void classesCanBeCategories() {
411411
}
412412

413413
@Category(SlowTests.class)
414-
public static abstract class Ancestor{}
414+
public abstract static class Ancestor{}
415415

416416
public static class Inherited extends Ancestor {
417417
@Test

src/test/java/org/junit/rules/DisableOnDebugTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public void evaluate() throws Throwable {
4848

4949
}
5050

51-
public static abstract class AbstractDisableOnDebugTest {
51+
public abstract static class AbstractDisableOnDebugTest {
5252

5353
@Rule
5454
public TestRule failOnExecution;

src/test/java/org/junit/rules/MethodRulesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public void nothing() {
4444
}
4545
}
4646

47-
static abstract class NonPublicExampleTest {
47+
abstract static class NonPublicExampleTest {
4848
@Rule
4949
public MethodRule example = new TestMethodRule();
5050

src/test/java/org/junit/rules/StopwatchTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ private static class Record {
4949
}
5050
}
5151

52-
public static abstract class AbstractStopwatchTest {
52+
public abstract static class AbstractStopwatchTest {
5353

5454
/**
5555
* Fake implementation of {@link Stopwatch.Clock} that increments the time

src/test/java/org/junit/tests/experimental/AssumptionTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,8 +237,8 @@ public void assumeWithExpectedExceptionShouldThrowAssumptionViolatedException()
237237
assertThat(result.getAssumptionFailureCount(), is(1));
238238
}
239239

240-
final static String message = "Some random message string.";
241-
final static Throwable e = new Throwable();
240+
static final String message = "Some random message string.";
241+
static final Throwable e = new Throwable();
242242

243243
/**
244244
* @see AssumptionTest#assumptionsWithMessage()

0 commit comments

Comments
 (0)