Skip to content

Commit 0edaf7c

Browse files
authored
Pass in a logger to get_metadata (#1176)
Without this, the log messages printed in #1171 don't actually make it out. Whoops! LoggingConfigurable inherits from HasTraits, and sets up Logging appropriately so we can have a log passed through.
1 parent 0948280 commit 0edaf7c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

jupyter_server/extension/manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def load(self, serverapp):
147147
return loader(serverapp)
148148

149149

150-
class ExtensionPackage(HasTraits):
150+
class ExtensionPackage(LoggingConfigurable):
151151
"""An API for interfacing with a Jupyter Server extension package.
152152
153153
Usage:
@@ -172,7 +172,7 @@ def _validate_name(self, proposed):
172172
name = proposed["value"]
173173
self._extension_points = {}
174174
try:
175-
self._module, self._metadata = get_metadata(name)
175+
self._module, self._metadata = get_metadata(name, self.log)
176176
except ImportError as e:
177177
msg = (
178178
f"The module '{name}' could not be found ({e}). Are you "

0 commit comments

Comments
 (0)