Skip to content

Commit 11f8c71

Browse files
committed
Don't reset the MultiKernelManager's default kernel name if the KernelSpecManager's default kernel name is set to be empty
1 parent 408cc88 commit 11f8c71

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

jupyter_server/services/kernels/kernelmanager.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,10 @@ def _default_default_kernel_name(self):
723723

724724
@observe("default_kernel_name")
725725
def _observe_default_kernel_name(self, change):
726-
if hasattr(self.kernel_spec_manager, "default_kernel_name"):
726+
if (
727+
hasattr(self.kernel_spec_manager, "default_kernel_name")
728+
and self.kernel_spec_manager.default_kernel_name
729+
):
727730
# If the kernel spec manager defines a default kernel name, treat that
728731
# one as authoritative.
729732
kernel_name = change.new
@@ -740,6 +743,8 @@ def _observe_default_kernel_name(self, change):
740743
def _on_kernel_spec_manager_default_kernel_name_changed(self, change):
741744
# Sync the kernel-spec-manager's trait to the multi-kernel-manager's trait.
742745
kernel_name = change.new
746+
if kernel_name is None:
747+
return
743748
self.log.debug(f"KernelSpecManager default kernel name changed: {kernel_name}")
744749
self.default_kernel_name = kernel_name
745750

0 commit comments

Comments
 (0)