Make the launch_timeout_pad be flow for consitency with other timeouts defined in this file

Author: CiprianAnton

jupyter_server/gateway/gateway_client.py

@@ -343,7 +343,7 @@ def gateway_retry_max_default(self):
 
     launch_timeout_pad_default_value = 2
     launch_timeout_pad_env = "JUPYTER_GATEWAY_LAUNCH_TIMEOUT_PAD"
-    launch_timeout_pad = Int(
+    launch_timeout_pad = Float(
         default_value=launch_timeout_pad_default_value,
         config=True,
         help="""Timeout pad to be ensured between KERNEL_LAUNCH_TIMEOUT and request_timeout
@@ -353,7 +353,7 @@ def gateway_retry_max_default(self):
 
     @default("launch_timeout_pad")
     def launch_timeout_pad_default(self):
-        return int(
+        return float(
             os.environ.get(
                 "JUPYTER_GATEWAY_LAUNCH_TIMEOUT_PAD",
                 self.launch_timeout_pad_default_value,
@@ -382,7 +382,7 @@ def init_static_args(self):
             self.request_timeout = minimum_request_timeout
         elif self.request_timeout > minimum_request_timeout:
             GatewayClient.KERNEL_LAUNCH_TIMEOUT = (
-                int(self.request_timeout) - self.launch_timeout_pad
+                int(self.request_timeout - self.launch_timeout_pad)
             )
         # Ensure any adjustments are reflected in env.
         os.environ["KERNEL_LAUNCH_TIMEOUT"] = str(GatewayClient.KERNEL_LAUNCH_TIMEOUT)

tests/test_gateway.py

@@ -186,7 +186,7 @@ def init_gateway(monkeypatch):
     monkeypatch.setenv("JUPYTER_GATEWAY_HTTP_USER", mock_http_user)
     monkeypatch.setenv("JUPYTER_GATEWAY_REQUEST_TIMEOUT", "44.4")
     monkeypatch.setenv("JUPYTER_GATEWAY_CONNECT_TIMEOUT", "44.4")
-    monkeypatch.setenv("JUPYTER_GATEWAY_LAUNCH_TIMEOUT_PAD", "1")
+    monkeypatch.setenv("JUPYTER_GATEWAY_LAUNCH_TIMEOUT_PAD", "1.1")
     yield
     GatewayClient.clear_instance()
 
@@ -199,7 +199,7 @@ async def test_gateway_env_options(init_gateway, jp_serverapp):
         jp_serverapp.gateway_config.connect_timeout == jp_serverapp.gateway_config.request_timeout
     )
     assert jp_serverapp.gateway_config.connect_timeout == 44.4
-    assert jp_serverapp.gateway_config.launch_timeout_pad == 1
+    assert jp_serverapp.gateway_config.launch_timeout_pad == 1.1
 
     GatewayClient.instance().init_static_args()
     assert GatewayClient.instance().KERNEL_LAUNCH_TIMEOUT == 43
@@ -211,7 +211,7 @@ async def test_gateway_cli_options(jp_configurable_serverapp):
         "--GatewayClient.http_user=" + mock_http_user,
         "--GatewayClient.connect_timeout=44.4",
         "--GatewayClient.request_timeout=96.0",
-        "--GatewayClient.launch_timeout_pad=6",
+        "--GatewayClient.launch_timeout_pad=5.1",
     ]
 
     GatewayClient.clear_instance()
@@ -222,7 +222,7 @@ async def test_gateway_cli_options(jp_configurable_serverapp):
     assert app.gateway_config.http_user == mock_http_user
     assert app.gateway_config.connect_timeout == 44.4
     assert app.gateway_config.request_timeout == 96.0
-    assert app.gateway_config.launch_timeout_pad == 6
+    assert app.gateway_config.launch_timeout_pad == 5.1
     GatewayClient.instance().init_static_args()
     assert (
         GatewayClient.instance().KERNEL_LAUNCH_TIMEOUT == 90