Skip to content

Commit 4a34e6a

Browse files
authored
fix issues with jupyter_events 0.5.0 (#972)
1 parent ee55c5f commit 4a34e6a

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

tests/services/events/mock_event.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
$id: event.mock.jupyter.org/message
1+
$id: http://event.mock.jupyter.org/message
22
version: 1
33
title: Message
44
description: |

tests/services/events/mockextension/mock_extension.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class MockEventHandler(JupyterHandler):
88
def get(self):
99
# Emit an event.
1010
self.event_logger.emit(
11-
schema_id="event.mockextension.jupyter.org/message",
11+
schema_id="http://event.mockextension.jupyter.org/message",
1212
data={"event_message": "Hello world, from mock extension!"},
1313
)
1414

tests/services/events/mockextension/mock_extension_event.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
$id: event.mockextension.jupyter.org/message
1+
$id: http://event.mockextension.jupyter.org/message
22
version: 1
33
title: Message
44
description: |

tests/services/events/test_api.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ async def test_subscribe_websocket(event_logger, jp_ws_fetch):
3131
ws = await jp_ws_fetch("/api/events/subscribe")
3232

3333
event_logger.emit(
34-
schema_id="event.mock.jupyter.org/message",
34+
schema_id="http://event.mock.jupyter.org/message",
3535
data={"event_message": "Hello, world!"},
3636
)
3737
# await event_logger.gather_listeners()
@@ -44,7 +44,7 @@ async def test_subscribe_websocket(event_logger, jp_ws_fetch):
4444

4545
payload_1 = """\
4646
{
47-
"schema_id": "event.mock.jupyter.org/message",
47+
"schema_id": "http://event.mock.jupyter.org/message",
4848
"version": 1,
4949
"data": {
5050
"event_message": "Hello, world!"
@@ -55,7 +55,7 @@ async def test_subscribe_websocket(event_logger, jp_ws_fetch):
5555

5656
payload_2 = """\
5757
{
58-
"schema_id": "event.mock.jupyter.org/message",
58+
"schema_id": "http://event.mock.jupyter.org/message",
5959
"version": 1,
6060
"data": {
6161
"event_message": "Hello, world!"
@@ -83,7 +83,7 @@ async def test_post_event(jp_fetch, event_logger_sink, payload):
8383

8484
payload_3 = """\
8585
{
86-
"schema_id": "event.mock.jupyter.org/message",
86+
"schema_id": "http://event.mock.jupyter.org/message",
8787
"data": {
8888
"event_message": "Hello, world!"
8989
}
@@ -101,7 +101,7 @@ async def test_post_event(jp_fetch, event_logger_sink, payload):
101101

102102
payload_5 = """\
103103
{
104-
"schema_id": "event.mock.jupyter.org/message",
104+
"schema_id": "http://event.mock.jupyter.org/message",
105105
"version": 1
106106
}
107107
"""
@@ -128,7 +128,7 @@ async def test_post_event_400(jp_fetch, event_logger, payload):
128128

129129
payload_7 = """\
130130
{
131-
"schema_id": "event.mock.jupyter.org/message",
131+
"schema_id": "http://event.mock.jupyter.org/message",
132132
"version": 1,
133133
"data": {
134134
"message": "Hello, world!"
@@ -138,7 +138,7 @@ async def test_post_event_400(jp_fetch, event_logger, payload):
138138

139139
payload_8 = """\
140140
{
141-
"schema_id": "event.mock.jupyter.org/message",
141+
"schema_id": "http://event.mock.jupyter.org/message",
142142
"version": 2,
143143
"data": {
144144
"message": "Hello, world!"

tests/services/events/test_extension.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ def jp_server_config():
99
"ServerApp": {
1010
"jpserver_extensions": {"tests.services.events.mockextension": True},
1111
},
12-
"EventBus": {"allowed_schemas": ["event.mockextension.jupyter.org/message"]},
12+
"EventBus": {"allowed_schemas": ["http://event.mockextension.jupyter.org/message"]},
1313
}
1414
return config
1515

0 commit comments

Comments
 (0)