Skip to content

Commit 631e075

Browse files
committed
rever winpty, try longer request timeouts
1 parent b86e72d commit 631e075

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

setup.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@
4949
'terminado>=0.8.3',
5050
'prometheus_client',
5151
"pywin32>=1.0 ; sys_platform == 'win32'",
52-
# TODO: terminado needs to add this?
53-
"pywinpty>=0.5 ; sys_platform == 'win32'"
5452
],
5553
extras_require = {
5654
'test': ['coverage', 'requests',

tests/test_files.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,21 @@ def maybe_hidden(request):
2121
return request.param
2222

2323

24+
25+
# double the defaults
26+
TIMEOUTS = dict(
27+
connect_timeout=40.0,
28+
request_timeout=40.0
29+
)
30+
2431
async def fetch_expect_200(jp_fetch, *path_parts):
25-
r = await jp_fetch('files', *path_parts, method='GET')
32+
r = await jp_fetch('files', *path_parts, method='GET', **TIMEOUTS)
2633
assert (r.body.decode() == path_parts[-1]), (path_parts, r.body)
2734

2835

2936
async def fetch_expect_404(jp_fetch, *path_parts):
3037
with pytest.raises(tornado.httpclient.HTTPClientError) as e:
31-
r = await jp_fetch('files', *path_parts, method='GET')
38+
r = await jp_fetch('files', *path_parts, method='GET', **TIMEOUTS)
3239
print(r.body)
3340
assert expected_http_error(e, 404), [path_parts, e]
3441

0 commit comments

Comments
 (0)