Skip to content

Commit 64555ff

Browse files
authored
flow kernel_id through start_kernel to enable reconnection/rehydration of gateway kernels (#788)
1 parent cc8bdf4 commit 64555ff

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

jupyter_server/gateway/managers.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ async def start_kernel(self, kernel_id=None, path=None, **kwargs):
7272
kwargs["cwd"] = self.cwd_for_path(path)
7373

7474
km = self.kernel_manager_factory(parent=self, log=self.log)
75-
await km.start_kernel(**kwargs)
75+
await km.start_kernel(kernel_id=kernel_id, **kwargs)
7676
kernel_id = km.kernel_id
7777
self._kernels[kernel_id] = km
7878

@@ -368,6 +368,7 @@ async def refresh_model(self, model=None):
368368
self.log.debug("Request kernel at: %s" % self.kernel_url)
369369
try:
370370
response = await gateway_request(self.kernel_url, method="GET")
371+
371372
except web.HTTPError as error:
372373
if error.status_code == 404:
373374
self.log.warning("Kernel not found at: %s" % self.kernel_url)
@@ -434,14 +435,14 @@ async def start_kernel(self, **kwargs):
434435
response = await gateway_request(self.kernels_url, method="POST", body=json_body)
435436
self.kernel = json_decode(response.body)
436437
self.kernel_id = self.kernel["id"]
438+
self.kernel_url = url_path_join(self.kernels_url, url_escape(str(self.kernel_id)))
437439
self.log.info(f"GatewayKernelManager started kernel: {self.kernel_id}, args: {kwargs}")
438440
else:
439441
self.kernel_id = kernel_id
442+
self.kernel_url = url_path_join(self.kernels_url, url_escape(str(self.kernel_id)))
440443
self.kernel = await self.refresh_model()
441444
self.log.info(f"GatewayKernelManager using existing kernel: {self.kernel_id}")
442445

443-
self.kernel_url = url_path_join(self.kernels_url, url_escape(str(self.kernel_id)))
444-
445446
async def shutdown_kernel(self, now=False, restart=False):
446447
"""Attempts to stop the kernel process cleanly via HTTP."""
447448

0 commit comments

Comments
 (0)