Skip to content

Commit 66e7526

Browse files
committed
Add opt-in allow_external_kernels flag
1 parent 349f383 commit 66e7526

File tree

1 file changed

+19
-4
lines changed

1 file changed

+19
-4
lines changed

jupyter_server/serverapp.py

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1643,7 +1643,17 @@ def _update_notebook_dir(self, change):
16431643
None,
16441644
allow_none=True,
16451645
config=True,
1646-
help=_i18n("The directory to look at for external kernel connection files."),
1646+
help=_i18n(
1647+
"The directory to look at for external kernel connection files, if allow_external_kernels is True. Defaults to Jupyter runtime_dir/external_kernels."
1648+
),
1649+
)
1650+
1651+
allow_external_kernels = Bool(
1652+
False,
1653+
config=True,
1654+
help=_i18n(
1655+
"Whether or not to allow external kernels, whose connection files are placed in external_connection_dir."
1656+
),
16471657
)
16481658

16491659
root_dir = Unicode(config=True, help=_i18n("The directory to use for notebooks and kernels."))
@@ -1881,9 +1891,14 @@ def init_configurables(self):
18811891
self.kernel_spec_manager = self.kernel_spec_manager_class(
18821892
parent=self,
18831893
)
1884-
external_connection_dir = self.external_connection_dir
1885-
if external_connection_dir is None:
1886-
external_connection_dir = str(Path(self.runtime_dir) / "external_kernels")
1894+
1895+
if self.allow_external_kernels:
1896+
external_connection_dir = self.external_connection_dir
1897+
if external_connection_dir is None:
1898+
external_connection_dir = str(Path(self.runtime_dir) / "external_kernels")
1899+
else:
1900+
external_connection_dir = None
1901+
18871902
self.kernel_manager = self.kernel_manager_class(
18881903
parent=self,
18891904
log=self.log,

0 commit comments

Comments
 (0)