Skip to content

Commit 6ad8006

Browse files
authored
Register websocket handler from same module as kernel handlers (#1249)
1 parent 5213ed4 commit 6ad8006

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

jupyter_server/serverapp.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@
164164
"files": ["jupyter_server.files.handlers"],
165165
"kernels": [
166166
"jupyter_server.services.kernels.handlers",
167-
"jupyter_server.services.kernels.websocket",
168167
],
169168
"kernelspecs": [
170169
"jupyter_server.kernelspecs.handlers",

jupyter_server/services/kernels/handlers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
from jupyter_server.utils import url_escape, url_path_join
2020

2121
from ...base.handlers import APIHandler
22+
from .websocket import KernelWebsocketHandler
2223

2324
AUTH_RESOURCE = "kernels"
2425

@@ -121,4 +122,5 @@ async def post(self, kernel_id, action):
121122
rf"/api/kernels/{_kernel_id_regex}/{_kernel_action_regex}",
122123
KernelActionHandler,
123124
),
125+
(r"/api/kernels/%s/channels" % _kernel_id_regex, KernelWebsocketHandler),
124126
]

jupyter_server/services/kernels/websocket.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
from jupyter_server.base.handlers import JupyterHandler
99
from jupyter_server.base.websocket import WebSocketMixin
1010

11-
from .handlers import _kernel_id_regex
12-
1311
AUTH_RESOURCE = "kernels"
1412

1513

@@ -94,8 +92,3 @@ def select_subprotocol(self, subprotocols):
9492
selected_subprotocol = preferred_protocol if preferred_protocol in subprotocols else None
9593
# None is the default, "legacy" protocol
9694
return selected_subprotocol
97-
98-
99-
default_handlers = [
100-
(r"/api/kernels/%s/channels" % _kernel_id_regex, KernelWebsocketHandler),
101-
]

0 commit comments

Comments
 (0)