Skip to content

Commit de1730d

Browse files
committed
Due to bad typing of kwargs it things that env is a str
but in fact it in general should be a dict
1 parent 8963d2f commit de1730d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

jupyter_server/services/kernels/kernelmanager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,8 @@ async def _async_start_kernel( # type:ignore[override]
247247
"Kernel args (excluding env): %r", {k: v for k, v in kwargs.items() if k != "env"}
248248
)
249249
env = kwargs.get("env", None)
250-
if env and isinstance(env, dict):
251-
self.log.debug("Kernel argument 'env' passed with: %r", list(env.keys()))
250+
if env and isinstance(env, dict): # type:ignore[unreachable]
251+
self.log.debug("Kernel argument 'env' passed with: %r", list(env.keys())) # type:ignore[unreachable]
252252

253253
# Increase the metric of number of kernels running
254254
# for the relevant kernel type by 1

0 commit comments

Comments
 (0)