Skip to content

Commit fd94f12

Browse files
committed
inject server config properly
1 parent d925e67 commit fd94f12

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ jobs:
1212
matrix:
1313
os: [ubuntu, macos, windows]
1414
python-version: [ '3.6', '3.7', '3.8', '3.9', 'pypy3' ]
15+
exclude:
16+
- os: windows
17+
PYTHON_VERSION: pypy3
1518
steps:
1619
- name: Checkout
1720
uses: actions/checkout@v1

examples/simple/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ git clone https://github.com/jupyter/jupyter_server && \
1212
cd examples/simple && \
1313
conda create -y -n jupyter-server-example python=3.7 && \
1414
conda activate jupyter-server-example && \
15-
pip install -e .
15+
pip install -e .[test]
1616
```
1717

1818
**OPTIONAL** If you want to build the Typescript code, you need [npm](https://www.npmjs.com) on your local environement. Compiled javascript is provided as artifact in this repository, so this Typescript build step is optional. The Typescript source and configuration have been taken from https://github.com/markellekelly/jupyter-server-example.

examples/simple/tests/test_handlers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33

44
@pytest.fixture
5-
def server_config(jp_template_dir):
5+
def jp_server_config(jp_template_dir):
66
return {
77
"ServerApp": {
88
"jpserver_extensions": {

0 commit comments

Comments
 (0)