-

Author: davidbrochart

tests/conftest.py

@@ -43,6 +43,10 @@ async def yws_server(request):
 @pytest.fixture
 def yjs_client(request):
     client_id = request.param
-    p = subprocess.Popen(f"yarn node {here / 'yjs_client_'}{client_id}.js", shell=True)
+    p = subprocess.Popen(["node", f"{here / 'yjs_client_'}{client_id}.js"])
     yield p
-    p.kill()
+    p.terminate()
+    try:
+        p.wait(timeout=10)
+    except Exception:
+        p.kill()

tests/test_pycrdt_yjs.py

@@ -79,11 +79,11 @@ async def test_ypy_yjs_0(yws_server, yjs_client):
 async def test_ypy_yjs_1(yws_server, yjs_client):
     ydoc = Doc()
     ynotebook = YNotebook(ydoc)
+    nb = stringify_source(json.loads((files_dir / "nb1.ipynb").read_text()))
+    ynotebook.source = nb
     async with connect("ws://localhost:1234/my-roomname") as websocket, WebsocketProvider(
         ydoc, websocket
     ):
-        nb = stringify_source(json.loads((files_dir / "nb1.ipynb").read_text()))
-        ynotebook.source = nb
         output_text = ynotebook.ycells[0]["outputs"][0]["text"]
         assert output_text.to_py() == ["Hello,"]
         event = Event()