Skip to content

Commit 9312bc4

Browse files
authored
Restore the ability to override the HTTP port a configurable serverapp listens on (#82)
When invoking the `jp_configurable_serverapp` fixture, there are multiple keyword arguments supported for overriding the values specified by other fixtures. One of those keyword arguments, `http_port`, is never used. I believe this was accidentally broken by #33 where multiple variables named `http_port` referencing a provided fixture were renamed to `jp_http_port`. However, that change also modified one instance of `http_port` that was not a reference to the fixture, but rather a reference to the keyword argument with that same name. This change fixes that by undoing that one line of the change.
1 parent b73fd26 commit 9312bc4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pytest_jupyter/jupyter_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ def _configurable_serverapp(
197197
app = ServerApp.instance(
198198
# Set the log level to debug for testing purposes
199199
log_level="DEBUG",
200-
port=jp_http_port,
200+
port=http_port,
201201
port_retries=0,
202202
open_browser=False,
203203
base_url=base_url,

0 commit comments

Comments
 (0)