Skip to content

Commit 14a29d1

Browse files
committed
Improve comments in images
1 parent 0386b2a commit 14a29d1

File tree

4 files changed

+17
-15
lines changed

4 files changed

+17
-15
lines changed

images/base-notebook/Dockerfile

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,18 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"]
1313

1414
USER root
1515

16-
# Install all OS dependencies for the Server that starts but lacks all
17-
# features (e.g., download as all possible file formats)
16+
# Install all OS dependencies for the Server that starts
17+
# but lacks all features (e.g., download as all possible file formats)
1818
RUN apt-get update --yes && \
1919
apt-get install --yes --no-install-recommends \
20+
# - Add necessary fonts for matplotlib/seaborn
21+
# See https://github.com/jupyter/docker-stacks/pull/380 for details
2022
fonts-liberation \
21-
# - pandoc is used to convert notebooks to html files
23+
# - `pandoc` is used to convert notebooks to html files
2224
# it's not present in the aarch64 Ubuntu image, so we install it here
2325
pandoc \
24-
# - run-one - a wrapper script that runs no more
25-
# than one unique instance of some command with a unique set of arguments,
26+
# - `run-one` - a wrapper script that runs no more
27+
# than one unique instance of some command with a unique set of arguments,
2628
# we use `run-one-constantly` to support the `RESTARTABLE` option
2729
run-one && \
2830
apt-get clean && rm -rf /var/lib/apt/lists/*

images/docker-stacks-foundation/Dockerfile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,18 @@ USER root
2222
# but lacks all features (e.g., download as all possible file formats)
2323
ENV DEBIAN_FRONTEND noninteractive
2424
RUN apt-get update --yes && \
25-
# - `apt-get upgrade` is run to patch known vulnerabilities in apt-get packages as
26-
# the Ubuntu base image is rebuilt too seldom sometimes (less than once a month)
25+
# - `apt-get upgrade` is run to patch known vulnerabilities in system packages
26+
# as the Ubuntu base image is rebuilt too seldom sometimes (less than once a month)
2727
apt-get upgrade --yes && \
2828
apt-get install --yes --no-install-recommends \
2929
# - bzip2 is necessary to extract the micromamba executable.
3030
bzip2 \
3131
ca-certificates \
3232
locales \
3333
sudo \
34-
# - tini is installed as a helpful container entrypoint that reaps zombie
35-
# processes and such of the actual executable we want to start, see
36-
# https://github.com/krallin/tini#why-tini for details.
34+
# - `tini` is installed as a helpful container entrypoint,
35+
# that reaps zombie processes and such of the actual executable we want to start
36+
# See https://github.com/krallin/tini#why-tini for details
3737
tini \
3838
wget && \
3939
apt-get clean && rm -rf /var/lib/apt/lists/* && \
@@ -102,6 +102,7 @@ RUN set -x && \
102102
# Should be simpler, see <https://github.com/mamba-org/mamba/issues/1437>
103103
arch="64"; \
104104
fi && \
105+
# https://mamba.readthedocs.io/en/latest/installation/micromamba-installation.html#linux-and-macos
105106
wget --progress=dot:giga -O - \
106107
"https://micro.mamba.pm/api/micromamba/linux-${arch}/latest" | tar -xvj bin/micromamba && \
107108
PYTHON_SPECIFIER="python=${PYTHON_VERSION}" && \

images/minimal-notebook/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ RUN apt-get update --yes && \
2525
vim-tiny \
2626
# git-over-ssh
2727
openssh-client \
28-
# less is needed to run help in R
28+
# `less` is needed to run help in R
2929
# see: https://github.com/jupyter/docker-stacks/issues/1588
3030
less \
31-
# nbconvert dependencies
31+
# `nbconvert` dependencies
3232
# https://nbconvert.readthedocs.io/en/latest/install.html#installing-tex
3333
texlive-xetex \
3434
texlive-fonts-recommended \

images/pyspark-notebook/ipython_kernel_config.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
# Logs are particularly verbose with Spark, that is why we turn them off through this flag.
88
# <https://github.com/jupyter/docker-stacks/issues/1423>
99

10-
# Attempt to capture and forward low-level output, e.g. produced by Extension
11-
# libraries.
12-
# Default: True
10+
# Attempt to capture and forward low-level output, e.g. produced by Extension libraries.
11+
# Default: True
1312
# type:ignore
1413
c.IPKernelApp.capture_fd_output = False # noqa: F821

0 commit comments

Comments
 (0)