Skip to content

Commit 28a0b25

Browse files
Install jupyterhub-base instead of jupyterhub (#2171)
* Install jupyterhub-base instead of jupyterhub * Update images/base-notebook/Dockerfile --------- Co-authored-by: Ayaz Salikhov <[email protected]>
1 parent 62a85b4 commit 28a0b25

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM quay.io/jupyter/base-notebook
22

3-
RUN mamba install --yes 'jupyterhub==4.0.1' && \
3+
RUN mamba install --yes 'jupyterhub-base==4.0.1' && \
44
mamba clean --all -f -y && \
55
fix-permissions "${CONDA_DIR}" && \
66
fix-permissions "/home/${NB_USER}"

images/base-notebook/Dockerfile

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,15 @@ USER ${NB_UID}
3939
# files across image layers when the permissions change
4040
WORKDIR /tmp
4141
RUN mamba install --yes \
42-
'jupyterhub' \
42+
'jupyterhub-base' \
4343
'jupyterlab' \
4444
'nbclassic' \
45+
# nodejs has historically been installed indirectly as a dependency.
46+
# When it was no longer getting installed indirectly,
47+
# we started installing it explicitly to avoid introducing a breaking change
48+
# for users building on top of these images.
49+
# See: https://github.com/jupyter/docker-stacks/pull/2171
50+
'nodejs' \
4551
# Sometimes, when the new version of `jupyterlab` is released, latest `notebook` might not support it for some time
4652
# Old versions of `notebook` (<v7) didn't have a restriction on the `jupyterlab` version, and old `notebook` is getting installed
4753
# That's why we have to pin the minimum notebook version

tests/docker-stacks-foundation/test_packages.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,10 @@
7474
"grpcio-status",
7575
"grpcio",
7676
"hdf5",
77+
"jupyterhub-base",
7778
"jupyterlab-git",
7879
"mamba[version='<2.0.0']",
80+
"nodejs",
7981
"notebook[version='>",
8082
"openssl",
8183
"pandas[version='>",

0 commit comments

Comments
 (0)