Skip to content

Commit 848a826

Browse files
committed
Fix build manifest image size and improve name
1 parent 2a6a10a commit 848a826

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

tagging/manifests.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,12 @@ def create_header(
3030
commit_hash_tag = GitHelper.commit_hash_tag()
3131
commit_message = GitHelper.commit_message()
3232

33+
# Unfortunately, docker images doesn't work when specifying `docker.io` as registry
34+
fixed_registry = registry + "/" if registry != "docker.io" else ""
35+
3336
image_size = docker[
3437
"images",
35-
f"{registry}/{owner}/{short_image_name}:latest",
38+
f"{fixed_registry}{owner}/{short_image_name}:latest",
3639
"--format",
3740
"{{.Size}}",
3841
]().rstrip()
@@ -44,7 +47,7 @@ def create_header(
4447
"## Build Info",
4548
"",
4649
f"* Build datetime: {build_timestamp}",
47-
f"* Docker image: {registry}/{owner}/{short_image_name}:{commit_hash_tag}",
50+
f"* Docker image: `{registry}/{owner}/{short_image_name}:{commit_hash_tag}`",
4851
f"* Docker image size: {image_size}",
4952
f"* Git commit SHA: [{commit_hash}](https://github.com/jupyter/docker-stacks/commit/{commit_hash})",
5053
"* Git commit message:",

0 commit comments

Comments
 (0)