Skip to content

Commit 87b37b4

Browse files
authored
Specify protocol when using host.docker.internal proxy (#2181)
1 parent 976fbab commit 87b37b4

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tests/base-notebook/test_healthcheck.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,10 @@ def test_healthy(
8282
"env,cmd,user",
8383
[
8484
(
85-
["HTTPS_PROXY=host.docker.internal", "HTTP_PROXY=host.docker.internal"],
85+
[
86+
"HTTPS_PROXY=https://host.docker.internal",
87+
"HTTP_PROXY=http://host.docker.internal",
88+
],
8689
None,
8790
None,
8891
),
@@ -91,8 +94,8 @@ def test_healthy(
9194
"NB_USER=testuser",
9295
"CHOWN_HOME=1",
9396
"JUPYTER_PORT=8123",
94-
"HTTPS_PROXY=host.docker.internal",
95-
"HTTP_PROXY=host.docker.internal",
97+
"HTTPS_PROXY=https://host.docker.internal",
98+
"HTTP_PROXY=http://host.docker.internal",
9699
],
97100
["start-notebook.py", "--ServerApp.base_url=/test"],
98101
"root",

0 commit comments

Comments
 (0)