Skip to content

Commit c2d9d1f

Browse files
authored
Pin min notebook version (#2167)
* [TMP] Pin min notebook version * Update Dockerfile
1 parent 5841857 commit c2d9d1f

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

images/base-notebook/Dockerfile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,11 @@ RUN mamba install --yes \
4242
'jupyterhub' \
4343
'jupyterlab' \
4444
'nbclassic' \
45-
'notebook' && \
45+
# Sometimes, when the new version of `jupyterlab` is released, latest `notebook` might not support it for some time
46+
# Old versions of `notebook` (<v7) didn't have a restriction on the `jupyterlab` version, and old `notebook` is getting installed
47+
# That's why we have to pin the minimum notebook version
48+
# More info: https://github.com/jupyter/docker-stacks/pull/2167
49+
'notebook>=7.2.2' && \
4650
jupyter server --generate-config && \
4751
mamba clean --all -f -y && \
4852
npm cache clean --force && \

tests/docker-stacks-foundation/test_packages.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@
7676
"hdf5",
7777
"jupyterlab-git",
7878
"mamba[version='<2.0.0']",
79+
"notebook[version='>",
7980
"openssl",
8081
"pandas[version='>",
8182
"protobuf",

0 commit comments

Comments
 (0)