Skip to content

Commit 51eff7b

Browse files
authored
Merge pull request #1038 from twalcari/patch-1
Validate JUPYTERHUB_SERVICE_URL port number
2 parents 8b013f7 + 1f2dd32 commit 51eff7b

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

nbviewer/app.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -458,6 +458,13 @@ def default_endpoint(self):
458458
if "JUPYTERHUB_SERVICE_URL" in os.environ:
459459
url = urlparse(os.environ["JUPYTERHUB_SERVICE_URL"])
460460
default_host, default_port = url.hostname, url.port
461+
462+
if default_port < 1 or default_port > 65535:
463+
self.log.error(
464+
"Received invalid port number %d through JUPYTERHUB_SERVICE_URL. "
465+
"Defaulting to 5000 instead."
466+
)
467+
default_port = 5000
461468
else:
462469
default_host, default_port = "0.0.0.0", 5000
463470
return {"host": default_host, "port": default_port}

0 commit comments

Comments
 (0)