space before the commetns

Author: honfika

README.md

@@ -30,7 +30,7 @@ For stable releases on [stable branch](https://github.com/justcoding121/Titanium
 Supports
 
  * .Net Standard 2.0 or above
- * .Net Framework 4.5 or above
+ * .Net Framework 4.6.1 or above
 
 ### Development environment
 
@@ -55,11 +55,11 @@ Setup HTTP proxy:
 ```csharp
 var proxyServer = new ProxyServer();
 
-//locally trust root certificate used by this proxy 
+// locally trust root certificate used by this proxy 
 proxyServer.CertificateManager.TrustRootCertificate = true;
 
-//optionally set the Certificate Engine
-//Under Mono only BouncyCastle will be supported
+// optionally set the Certificate Engine
+// Under Mono only BouncyCastle will be supported
 //proxyServer.CertificateManager.CertificateEngine = Network.CertificateEngine.BouncyCastle;
 
 proxyServer.BeforeRequest += OnRequest;
@@ -70,28 +70,28 @@ proxyServer.ClientCertificateSelectionCallback += OnCertificateSelection;
 
 var explicitEndPoint = new ExplicitProxyEndPoint(IPAddress.Any, 8000, true)
 {
-//Use self-issued generic certificate on all https requests
-//Optimizes performance by not creating a certificate for each https-enabled domain
-//Useful when certificate trust is not required by proxy clients
-//GenericCertificate = new X509Certificate2(Path.Combine(System.IO.Path.GetDirectoryName(System.Reflection.Assembly.GetExecutingAssembly().Location), "genericcert.pfx"), "password")
+    // Use self-issued generic certificate on all https requests
+    // Optimizes performance by not creating a certificate for each https-enabled domain
+    // Useful when certificate trust is not required by proxy clients
+   //GenericCertificate = new X509Certificate2(Path.Combine(System.IO.Path.GetDirectoryName(System.Reflection.Assembly.GetExecutingAssembly().Location), "genericcert.pfx"), "password")
 };
 
-//Fired when a CONNECT request is received
+// Fired when a CONNECT request is received
 explicitEndPoint.BeforeTunnelConnect += OnBeforeTunnelConnect;
 
-//An explicit endpoint is where the client knows about the existence of a proxy
-//So client sends request in a proxy friendly manner
+// An explicit endpoint is where the client knows about the existence of a proxy
+// So client sends request in a proxy friendly manner
 proxyServer.AddEndPoint(explicitEndPoint);
 proxyServer.Start();
 
-//Transparent endpoint is useful for reverse proxy (client is not aware of the existence of proxy)
-//A transparent endpoint usually requires a network router port forwarding HTTP(S) packets or DNS
-//to send data to this endPoint
+// Transparent endpoint is useful for reverse proxy (client is not aware of the existence of proxy)
+// A transparent endpoint usually requires a network router port forwarding HTTP(S) packets or DNS
+// to send data to this endPoint
 var transparentEndPoint = new TransparentProxyEndPoint(IPAddress.Any, 8001, true)
 {
-	//Generic Certificate hostname to use
-	//when SNI is disabled by client
-	GenericCertificateName = "google.com"
+    // Generic Certificate hostname to use
+    // when SNI is disabled by client
+    GenericCertificateName = "google.com"
 };
 
 proxyServer.AddEndPoint(transparentEndPoint);
@@ -103,36 +103,36 @@ foreach (var endPoint in proxyServer.ProxyEndPoints)
 Console.WriteLine("Listening on '{0}' endpoint at Ip {1} and port: {2} ",
     endPoint.GetType().Name, endPoint.IpAddress, endPoint.Port);
 
-//Only explicit proxies can be set as system proxy!
+// Only explicit proxies can be set as system proxy!
 proxyServer.SetAsSystemHttpProxy(explicitEndPoint);
 proxyServer.SetAsSystemHttpsProxy(explicitEndPoint);
 
-//wait here (You can use something else as a wait function, I am using this as a demo)
+// wait here (You can use something else as a wait function, I am using this as a demo)
 Console.Read();
 
-//Unsubscribe & Quit
+// Unsubscribe & Quit
 explicitEndPoint.BeforeTunnelConnect -= OnBeforeTunnelConnect;
 proxyServer.BeforeRequest -= OnRequest;
 proxyServer.BeforeResponse -= OnResponse;
 proxyServer.ServerCertificateValidationCallback -= OnCertificateValidation;
 proxyServer.ClientCertificateSelectionCallback -= OnCertificateSelection;
 
 proxyServer.Stop();
-	
+    
 ```
 Sample request and response event handlers
 
-```csharp		
+```csharp        
 
 private async Task OnBeforeTunnelConnectRequest(object sender, TunnelConnectSessionEventArgs e)
 {
     string hostname = e.HttpClient.Request.RequestUri.Host;
 
     if (hostname.Contains("dropbox.com"))
     {
-         //Exclude Https addresses you don't want to proxy
-         //Useful for clients that use certificate pinning
-         //for example dropbox.com
+         // Exclude Https addresses you don't want to proxy
+         // Useful for clients that use certificate pinning
+         // for example dropbox.com
          e.DecryptSsl = false;
     }
 }
@@ -141,88 +141,88 @@ public async Task OnRequest(object sender, SessionEventArgs e)
 {
     Console.WriteLine(e.HttpClient.Request.Url);
 
-    ////read request headers
+    // read request headers
     var requestHeaders = e.HttpClient.Request.RequestHeaders;
 
     var method = e.HttpClient.Request.Method.ToUpper();
     if ((method == "POST" || method == "PUT" || method == "PATCH"))
     {
-	//Get/Set request body bytes
-	byte[] bodyBytes = await e.GetRequestBody();
-	await e.SetRequestBody(bodyBytes);
-
-	//Get/Set request body as string
-	string bodyString = await e.GetRequestBodyAsString();
-	await e.SetRequestBodyString(bodyString);
-	
-	//store request 
-	//so that you can find it from response handler 
-  	e.UserData = e.HttpClient.Request;
+        // Get/Set request body bytes
+        byte[] bodyBytes = await e.GetRequestBody();
+        await e.SetRequestBody(bodyBytes);
+
+        // Get/Set request body as string
+        string bodyString = await e.GetRequestBodyAsString();
+        await e.SetRequestBodyString(bodyString);
+    
+        // store request 
+        // so that you can find it from response handler 
+        e.UserData = e.HttpClient.Request;
     }
 
-    //To cancel a request with a custom HTML content
-    //Filter URL
+    // To cancel a request with a custom HTML content
+    // Filter URL
     if (e.HttpClient.Request.RequestUri.AbsoluteUri.Contains("google.com"))
     {
-	e.Ok("<!DOCTYPE html>" +
-	      "<html><body><h1>" +
-	      "Website Blocked" +
-	      "</h1>" +
-	      "<p>Blocked by titanium web proxy.</p>" +
-	      "</body>" +
-	      "</html>");
+        e.Ok("<!DOCTYPE html>" +
+            "<html><body><h1>" +
+            "Website Blocked" +
+            "</h1>" +
+            "<p>Blocked by titanium web proxy.</p>" +
+            "</body>" +
+            "</html>");
     }
-    //Redirect example
+
+    // Redirect example
     if (e.HttpClient.Request.RequestUri.AbsoluteUri.Contains("wikipedia.org"))
     {
-	e.Redirect("https://www.paypal.com");
+        e.Redirect("https://www.paypal.com");
     }
 }
 
-//Modify response
+// Modify response
 public async Task OnResponse(object sender, SessionEventArgs e)
 {
-    //read response headers
+    // read response headers
     var responseHeaders = e.HttpClient.Response.ResponseHeaders;
 
     //if (!e.ProxySession.Request.Host.Equals("medeczane.sgk.gov.tr")) return;
     if (e.HttpClient.Request.Method == "GET" || e.HttpClient.Request.Method == "POST")
     {
-	if (e.HttpClient.Response.ResponseStatusCode == "200")
-	{
-	    if (e.HttpClient.Response.ContentType!=null && e.HttpClient.Response.ContentType.Trim().ToLower().Contains("text/html"))
-	    {
-		byte[] bodyBytes = await e.GetResponseBody();
-		await e.SetResponseBody(bodyBytes);
-
-		string body = await e.GetResponseBodyAsString();
-		await e.SetResponseBodyString(body);
-	    }
-	}
+        if (e.HttpClient.Response.ResponseStatusCode == "200")
+        {
+            if (e.HttpClient.Response.ContentType!=null && e.HttpClient.Response.ContentType.Trim().ToLower().Contains("text/html"))
+            {
+                byte[] bodyBytes = await e.GetResponseBody();
+                await e.SetResponseBody(bodyBytes);
+
+                string body = await e.GetResponseBodyAsString();
+                await e.SetResponseBodyString(body);
+            }
+        }
     }
 
-    if(e.UserData!=null)
+    if (e.UserData!=null)
     {
-	    //access request from UserData property where we stored it in RequestHandler
-	    var request = (Request)e.UserData;
+        // access request from UserData property where we stored it in RequestHandler
+        var request = (Request)e.UserData;
     }
-    
 }
 
-/// Allows overriding default certificate validation logic
+// Allows overriding default certificate validation logic
 public Task OnCertificateValidation(object sender, CertificateValidationEventArgs e)
 {
-    //set IsValid to true/false based on Certificate Errors
+    // set IsValid to true/false based on Certificate Errors
     if (e.SslPolicyErrors == System.Net.Security.SslPolicyErrors.None)
-	e.IsValid = true;
+        e.IsValid = true;
 
     return Task.FromResult(0);
 }
 
-/// Allows overriding default client certificate selection logic during mutual authentication
+// Allows overriding default client certificate selection logic during mutual authentication
 public Task OnCertificateSelection(object sender, CertificateSelectionEventArgs e)
 {
-    //set e.clientCertificate to override
+    // set e.clientCertificate to override
     return Task.FromResult(0);
 }
 ```

examples/Titanium.Web.Proxy.Examples.Basic/ProxyTestController.cs

@@ -193,7 +193,7 @@ private async Task onResponse(object sender, SessionEventArgs e)
 
             string ext = System.IO.Path.GetExtension(e.HttpClient.Request.RequestUri.AbsolutePath);
 
-            //access user data set in request to do something with it
+            // access user data set in request to do something with it
             //var userData = e.HttpClient.UserData as CustomUserData;
 
             //if (ext == ".gif" || ext == ".png" || ext == ".jpg")

src/Titanium.Web.Proxy/EventArguments/SessionEventArgs.cs

@@ -615,36 +615,36 @@ public void Redirect(string url, bool closeServerConnection = false)
         /// <param name="closeServerConnection">Close the server connection used by request if any?</param>
         public void Respond(Response response, bool closeServerConnection = false)
         {
-            //request already send/ready to be sent.
+            // request already send/ready to be sent.
             if (HttpClient.Request.Locked)
             {
-                //response already received from server and ready to be sent to client.
+                // response already received from server and ready to be sent to client.
                 if (HttpClient.Response.Locked)
                 {
                     throw new Exception("You cannot call this function after response is sent to the client.");
                 }
 
-                //cleanup original response.
+                // cleanup original response.
                 if (closeServerConnection)
                 {
-                    //no need to cleanup original connection.
-                    //it will be closed any way.
+                    // no need to cleanup original connection.
+                    // it will be closed any way.
                     TerminateServerConnection();
                 }
 
                 response.SetOriginalHeaders(HttpClient.Response);
 
-                //response already received from server but not yet ready to sent to client.         
+                // response already received from server but not yet ready to sent to client.         
                 HttpClient.Response = response;
                 HttpClient.Response.Locked = true;
             }
-            //request not yet sent/not yet ready to be sent.
+            // request not yet sent/not yet ready to be sent.
             else
             {
                 HttpClient.Request.Locked = true;
                 HttpClient.Request.CancelRequest = true;
 
-                //set new response.
+                // set new response.
                 HttpClient.Response = response;
                 HttpClient.Response.Locked = true;
             }

src/Titanium.Web.Proxy/ExplicitClientHandler.cs

@@ -152,7 +152,8 @@ await clientStreamWriter.WriteResponseAsync(connectArgs.HttpClient.Response,
 
                                 http2Supported = connection.NegotiatedApplicationProtocol ==
                                                  SslApplicationProtocol.Http2;
-                                //release connection back to pool instead of closing when connection pool is enabled.
+                                
+                                // release connection back to pool instead of closing when connection pool is enabled.
                                 await tcpConnectionFactory.Release(connection, true);
                             }
                             catch (Exception)

src/Titanium.Web.Proxy/Extensions/TcpExtensions.cs

@@ -50,11 +50,11 @@ internal static bool IsGoodConnection(this TcpClient client)
 
                 socket.Blocking = false;
                 socket.Send(tmp, 0, 0);
-                //Connected.
+                // Connected.
             }
             catch
             {
-                //Should we let 10035 == WSAEWOULDBLOCK as valid connection?
+                // Should we let 10035 == WSAEWOULDBLOCK as valid connection?
                 return false;
             }
             finally

src/Titanium.Web.Proxy/Helpers/Network.cs

@@ -41,7 +41,7 @@ internal static bool IsLocalIpAddress(string hostName)
                 return true;
             }
 
-            //if hostname matches local host name
+            // if hostname matches local host name
             if (hostName.Equals(localhostName, StringComparison.OrdinalIgnoreCase))
             {
                 return true;

src/Titanium.Web.Proxy/Helpers/RunTime.cs

@@ -42,7 +42,7 @@ public static class RunTime
 
         public static bool IsMac => isRunningOnMac;
 
-        //https://github.com/qmatteoq/DesktopBridgeHelpers/blob/master/DesktopBridge.Helpers/Helpers.cs
+        // https://github.com/qmatteoq/DesktopBridgeHelpers/blob/master/DesktopBridge.Helpers/Helpers.cs
         private class UwpHelper
         {
             const long APPMODEL_ERROR_NO_PACKAGE = 15700L;

src/Titanium.Web.Proxy/Network/RetryPolicy.cs

@@ -37,10 +37,10 @@ internal async Task<RetryResult> ExecuteAsync(Func<TcpServerConnection, Task<boo
             {
                 try
                 {
-                    //setup connection
+                    // setup connection
                     currentConnection = currentConnection as TcpServerConnection ??
                                       await generator();
-                    //try
+                    // try
                     @continue = await action(currentConnection);
 
                 }
@@ -65,12 +65,12 @@ internal async Task<RetryResult> ExecuteAsync(Func<TcpServerConnection, Task<boo
             return new RetryResult(currentConnection, exception, @continue);
         }
 
-        //before retry clear connection
+        // before retry clear connection
         private async Task disposeConnection()
         {
             if (currentConnection != null)
             {
-                //close connection on error
+                // close connection on error
                 await tcpConnectionFactory.Release(currentConnection, true);
                 currentConnection = null;
             }

src/Titanium.Web.Proxy/Network/Tcp/TcpClientConnection.cs

@@ -82,9 +82,9 @@ public void Dispose()
         {
             Task.Run(async () =>
             {
-                //delay calling tcp connection close()
-                //so that client have enough time to call close first.
-                //This way we can push tcp Time_Wait to client side when possible.
+                // delay calling tcp connection close()
+                // so that client have enough time to call close first.
+                // This way we can push tcp Time_Wait to client side when possible.
                 await Task.Delay(1000);
                 proxyServer.UpdateClientConnectionCount(false);
                 tcpClient.CloseSocket();