Add runtime test for inject, log and signal

Author: fanzhangio

Gopkg.lock

@@ -43,7 +43,10 @@ func (c *FakeInformers) GetInformerForKind(gvk schema.GroupVersionKind) (toolsca
 	if c.Scheme == nil {
 		c.Scheme = scheme.Scheme
 	}
-	obj, _ := c.Scheme.New(gvk)
+	obj, err := c.Scheme.New(gvk)
+	if err != nil {
+		return nil, err
+	}
 	return c.informerFor(gvk, obj)
 }
 
@@ -52,7 +55,10 @@ func (c *FakeInformers) FakeInformerForKind(gvk schema.GroupVersionKind) (*contr
 	if c.Scheme == nil {
 		c.Scheme = scheme.Scheme
 	}
-	obj, _ := c.Scheme.New(gvk)
+	obj, err := c.Scheme.New(gvk)
+	if err != nil {
+		return nil, err
+	}
 	i, err := c.informerFor(gvk, obj)
 	if err != nil {
 		return nil, err
@@ -65,7 +71,10 @@ func (c *FakeInformers) GetInformer(obj runtime.Object) (toolscache.SharedIndexI
 	if c.Scheme == nil {
 		c.Scheme = scheme.Scheme
 	}
-	gvks, _, _ := c.Scheme.ObjectKinds(obj)
+	gvks, _, err := c.Scheme.ObjectKinds(obj)
+	if err != nil {
+		return nil, err
+	}
 	gvk := gvks[0]
 	return c.informerFor(gvk, obj)
 }
@@ -83,7 +92,10 @@ func (c *FakeInformers) FakeInformerFor(obj runtime.Object) (*controllertest.Fak
 	if c.Scheme == nil {
 		c.Scheme = scheme.Scheme
 	}
-	gvks, _, _ := c.Scheme.ObjectKinds(obj)
+	gvks, _, err := c.Scheme.ObjectKinds(obj)
+	if err != nil {
+		return nil, err
+	}
 	gvk := gvks[0]
 	i, err := c.informerFor(gvk, obj)
 	if err != nil {

pkg/cache/informertest/fake_cache.go

@@ -16,11 +16,10 @@ limitations under the License.
 
 package manager
 
-//
-//func SetCacheForTest(options *Options, c func(config *rest.Config, opts cache.Options) (cache.Cache, error)) {
-//	options.newCache = c
-//}
-//
-//func SetClientForTest(options *Options, c func(config *rest.Config, options client.Options) (client.Client, error)) {
-//	options.newClient = c
-//}
+// func SetCacheForTest(options *Options, c func(config *rest.Config, opts cache.Options) (cache.Cache, error)) {
+// 	options.newCache = c
+// }
+
+// func SetClientForTest(options *Options, c func(config *rest.Config, options client.Options) (client.Client, error)) {
+// 	options.newClient = c
+// }

pkg/manager/testutil.go

@@ -0,0 +1,30 @@
+/*
+Copyright 2018 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package inject
+
+import (
+	"testing"
+
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+	"sigs.k8s.io/controller-runtime/pkg/test"
+)
+
+func TestSource(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecsWithDefaultAndCustomReporters(t, "Runtime Injection Suite", []Reporter{test.NewlineReporter{}})
+}