Merge pull request kubernetes-sigs#178 from droot/ctrl-add-watches-after-start

do not hold the lock after controller has started

Author: k8s-ci-robot

pkg/internal/controller/controller.go

@@ -125,7 +125,6 @@ func (c *Controller) Watch(src source.Source, evthdler handler.EventHandler, prc
 // Start implements controller.Controller
 func (c *Controller) Start(stop <-chan struct{}) error {
 	c.mu.Lock()
-	defer c.mu.Unlock()
 
 	// TODO(pwittrock): Reconsider HandleCrash
 	defer utilruntime.HandleCrash()
@@ -143,6 +142,7 @@ func (c *Controller) Start(stop <-chan struct{}) error {
 		// Leaving it here because that could happen in the future
 		err := fmt.Errorf("failed to wait for %s caches to sync", c.Name)
 		log.Error(err, "Could not wait for Cache to sync", "Controller", c.Name)
+		c.mu.Unlock()
 		return err
 	}
 
@@ -161,6 +161,7 @@ func (c *Controller) Start(stop <-chan struct{}) error {
 	}
 
 	c.Started = true
+	c.mu.Unlock()
 
 	<-stop
 	log.Info("Stopping workers", "Controller", c.Name)